diff options
| author | Michael Brown | 2024-03-04 13:08:01 +0100 |
|---|---|---|
| committer | Michael Brown | 2024-03-04 13:15:20 +0100 |
| commit | 1b23d4de25d1dacf164eec442780bbfb026fbda7 (patch) | |
| tree | 00a2ec8e75460811802c129cf4a74f49e9509206 | |
| parent | [parseopt] Add parse_uuid() for parsing UUID command-line arguments (diff) | |
| download | ipxe-1b23d4de25d1dacf164eec442780bbfb026fbda7.tar.gz ipxe-1b23d4de25d1dacf164eec442780bbfb026fbda7.tar.xz ipxe-1b23d4de25d1dacf164eec442780bbfb026fbda7.zip | |
[efi] Use long forms of device paths in debug messages
We currently call ConvertDevicePathToText() with DisplayOnly=TRUE when
constructing a device path to appear within a debug message. For
ATAPI device paths, this will unfortunately omit some key information:
the textual representation will not indicate which ATA bus or drive is
represented. This can lead to misleading debug messages that appear
to refer to identical devices.
Fix by setting DisplayOnly=FALSE to select the long form of device
path textual representations.
Signed-off-by: Michael Brown <mcb30@ipxe.org>
| -rw-r--r-- | src/interface/efi/efi_debug.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/interface/efi/efi_debug.c b/src/interface/efi/efi_debug.c index ad79f0d3..52efebe5 100644 --- a/src/interface/efi/efi_debug.c +++ b/src/interface/efi/efi_debug.c @@ -479,7 +479,7 @@ efi_devpath_text ( EFI_DEVICE_PATH_PROTOCOL *path ) { } /* Convert path to a textual representation */ - wtext = efidpt->ConvertDevicePathToText ( path, TRUE, FALSE ); + wtext = efidpt->ConvertDevicePathToText ( path, FALSE, FALSE ); if ( ! wtext ) return NULL; |