summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Brown2008-09-30 01:38:10 +0200
committerMichael Brown2008-10-01 09:11:03 +0200
commitdf02c54f867227a4da2e8d5782efdcc602d2ade2 (patch)
tree044398eb2fa558a0c44a8e311b3fbaca21e9cfe7
parent[hermon] Fix off-by-one error in the failure path in hermon_probe() (diff)
downloadipxe-df02c54f867227a4da2e8d5782efdcc602d2ade2.tar.gz
ipxe-df02c54f867227a4da2e8d5782efdcc602d2ade2.tar.xz
ipxe-df02c54f867227a4da2e8d5782efdcc602d2ade2.zip
[arbel] Fix off-by-one error in the failure path in arbel_probe()
-rw-r--r--src/drivers/infiniband/arbel.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/drivers/infiniband/arbel.c b/src/drivers/infiniband/arbel.c
index 0c180833..1b55131b 100644
--- a/src/drivers/infiniband/arbel.c
+++ b/src/drivers/infiniband/arbel.c
@@ -2183,9 +2183,9 @@ static int arbel_probe ( struct pci_device *pci,
return 0;
- i = ( ARBEL_NUM_PORTS - 1 );
+ i = ARBEL_NUM_PORTS;
err_register_ibdev:
- for ( ; i >= 0 ; i-- )
+ for ( i-- ; i >= 0 ; i-- )
unregister_ibdev ( arbel->ibdev[i] );
arbel_destroy_eq ( arbel );
err_create_eq:
@@ -2201,9 +2201,9 @@ static int arbel_probe ( struct pci_device *pci,
err_mailbox_out:
free_dma ( arbel->mailbox_in, ARBEL_MBOX_SIZE );
err_mailbox_in:
- i = ( ARBEL_NUM_PORTS - 1 );
+ i = ARBEL_NUM_PORTS;
err_alloc_ibdev:
- for ( ; i >= 0 ; i-- )
+ for ( i-- ; i >= 0 ; i-- )
ibdev_put ( arbel->ibdev[i] );
free ( arbel );
err_alloc_arbel: