summaryrefslogtreecommitdiffstats
path: root/contrib/ppmtoansi
diff options
context:
space:
mode:
authorMichael Brown2009-01-27 16:47:00 +0100
committerMichael Brown2009-01-27 16:47:00 +0100
commit1284773363034e3afaf6d55b983e5aeeff44d59c (patch)
tree875425b07042a5ace82f3803289ac653afd50014 /contrib/ppmtoansi
parent[dhcp] Include support for PXE boot menus (diff)
downloadipxe-1284773363034e3afaf6d55b983e5aeeff44d59c.tar.gz
ipxe-1284773363034e3afaf6d55b983e5aeeff44d59c.tar.xz
ipxe-1284773363034e3afaf6d55b983e5aeeff44d59c.zip
[tftp] Temporary fix for conveying TFTP block size to callers
pxe_tftp.c assumes that the first seek on its data-transfer interface represents the block size. Apart from being an ugly hack, this will also screw up file size calculation for files smaller than one block. The proper solution would be to extend the data-transfer interface to support the reporting of stat()-like data. This is not going to happen until the cost of adding interface methods is reduced (a fix I have planned since June 2008). In the meantime, abuse the xfer_window() method to return the block size, since it is not being used for anything else and is vaguely justifiable. Astonishingly, having returned the incorrect TFTP blocksize via PXENV_TFTP_OPEN for almost a year seems not to have affected any of the test cases run during that time; this bug was found only when someone tried running the heavily-patched version of pxegrub found in OpenSolaris.
Diffstat (limited to 'contrib/ppmtoansi')
0 files changed, 0 insertions, 0 deletions