diff options
| author | Michael Brown | 2021-01-03 20:12:41 +0100 |
|---|---|---|
| committer | Michael Brown | 2021-01-03 21:23:51 +0100 |
| commit | 5aa389593dded9a45a2d2b83f3c1c65b2770fb82 (patch) | |
| tree | c89e3b4c015795f20ad6f8d583881994a65c5435 /src/core/stringextra.c | |
| parent | [xhci] Show meaningful error messages after command failures (diff) | |
| download | ipxe-5aa389593dded9a45a2d2b83f3c1c65b2770fb82.tar.gz ipxe-5aa389593dded9a45a2d2b83f3c1c65b2770fb82.tar.xz ipxe-5aa389593dded9a45a2d2b83f3c1c65b2770fb82.zip | |
[efi] Leave asynchronous USB endpoints open until device is removed
Some UEFI device drivers will react to an asynchronous USB transfer
failure by dubiously terminating the scheduled transfer from within
the completion handler.
We already have code from commit fbb776f ("[efi] Leave USB endpoint
descriptors in existence until device is removed") that avoids freeing
memory in this situation, in order to avoid use-after-free bugs. This
is not sufficient to avoid potential problems, since with an xHCI
controller the act of closing the endpoint requires issuing a command
and awaiting completion via the event ring, which may in turn dispatch
further USB transfer completion events.
Avoid these problems by leaving the USB endpoint open (but with the
refill timer stopped) until the device is finally removed, as is
already done for control and bulk transfers.
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/core/stringextra.c')
0 files changed, 0 insertions, 0 deletions