diff options
| author | Michael Brown | 2007-01-04 05:20:08 +0100 |
|---|---|---|
| committer | Michael Brown | 2007-01-04 05:20:08 +0100 |
| commit | 0c03bb5a9a0649ec7009e334c0e42290af330437 (patch) | |
| tree | d523c7ba2ae84b0998b7e8121d70a603d6fd087a /src/drivers/net/rtl8139.c | |
| parent | We *should* use the persistent reference API for our netdev reference, (diff) | |
| download | ipxe-0c03bb5a9a0649ec7009e334c0e42290af330437.tar.gz ipxe-0c03bb5a9a0649ec7009e334c0e42290af330437.tar.xz ipxe-0c03bb5a9a0649ec7009e334c0e42290af330437.zip | |
Make open() and close() an official part of the netdevice API.
Call netdevice's poll() and transmit() methods only when device is open.
Diffstat (limited to 'src/drivers/net/rtl8139.c')
| -rw-r--r-- | src/drivers/net/rtl8139.c | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/src/drivers/net/rtl8139.c b/src/drivers/net/rtl8139.c index 86c9c805..4592ed7d 100644 --- a/src/drivers/net/rtl8139.c +++ b/src/drivers/net/rtl8139.c @@ -542,8 +542,8 @@ static int rtl_probe ( struct pci_device *pci, nvs_read ( &rtl->eeprom.nvs, EE_MAC, netdev->ll_addr, ETH_ALEN ); /* Point to NIC specific routines */ - // netdev->open = rtl_open; - // netdev->close = rtl_close; + netdev->open = rtl_open; + netdev->close = rtl_close; netdev->transmit = rtl_transmit; netdev->poll = rtl_poll; @@ -558,10 +558,6 @@ static int rtl_probe ( struct pci_device *pci, goto err; } -#warning "Hack alert" - rtl_open ( netdev ); - - return 0; err: @@ -584,10 +580,6 @@ static void rtl_remove ( struct pci_device *pci ) { struct net_device *netdev = pci_get_drvdata ( pci ); struct rtl8139_nic *rtl = netdev->priv; - -#warning "Hack alert" - rtl_close ( netdev ); - if ( rtl->nvo.nvs ) nvo_unregister ( &rtl->nvo ); unregister_netdev ( netdev ); |