summaryrefslogtreecommitdiffstats
path: root/src/hci
diff options
context:
space:
mode:
authorMichael Brown2008-03-18 01:48:23 +0100
committerMichael Brown2008-03-18 01:48:23 +0100
commit5a08b434c7ddecb9cab0f8aedd9db679ca35395c (patch)
tree661b193f21aeaf89aafaf8d92d28ae39444f85aa /src/hci
parentMerge branch 'pxerom-pmm' (diff)
downloadipxe-5a08b434c7ddecb9cab0f8aedd9db679ca35395c.tar.gz
ipxe-5a08b434c7ddecb9cab0f8aedd9db679ca35395c.tar.xz
ipxe-5a08b434c7ddecb9cab0f8aedd9db679ca35395c.zip
[Settings] show_setting() functions return snprintf()-style length.
show_setting() and related functions now return an "actual length" in the style of snprintf(). This is to allow consumers to allocate buffers large enough to hold the formatted setting.
Diffstat (limited to 'src/hci')
-rw-r--r--src/hci/commands/nvo_cmd.c2
-rw-r--r--src/hci/tui/settings_ui.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/hci/commands/nvo_cmd.c b/src/hci/commands/nvo_cmd.c
index 4392787b..4c453c77 100644
--- a/src/hci/commands/nvo_cmd.c
+++ b/src/hci/commands/nvo_cmd.c
@@ -28,7 +28,7 @@ static int show_exec ( int argc, char **argv ) {
dummy_context.options = ugly_nvo_hack->options;
if ( ( rc = show_named_setting ( &dummy_context, argv[1], buf,
- sizeof ( buf ) ) ) != 0 ) {
+ sizeof ( buf ) ) ) < 0 ) {
printf ( "Could not find \"%s\": %s\n",
argv[1], strerror ( -rc ) );
return 1;
diff --git a/src/hci/tui/settings_ui.c b/src/hci/tui/settings_ui.c
index 336af4e9..c6261c77 100644
--- a/src/hci/tui/settings_ui.c
+++ b/src/hci/tui/settings_ui.c
@@ -118,7 +118,7 @@ static void load_setting ( struct setting_widget *widget ) {
/* Read current setting value */
if ( show_setting ( widget->context, widget->setting,
- widget->value, sizeof ( widget->value ) ) != 0 ) {
+ widget->value, sizeof ( widget->value ) ) < 0 ) {
widget->value[0] = '\0';
}