diff options
| author | Michael Brown | 2023-07-04 15:17:48 +0200 |
|---|---|---|
| committer | Michael Brown | 2023-07-04 15:17:48 +0200 |
| commit | cc07ed7c7ede8dfc79643ccabb32285c74d6bff5 (patch) | |
| tree | 848bcdcc45c5c7592b012e1323b7d178c3ce5c89 /src/image | |
| parent | [build] Use separate code segment if supported by linker (diff) | |
| download | ipxe-cc07ed7c7ede8dfc79643ccabb32285c74d6bff5.tar.gz ipxe-cc07ed7c7ede8dfc79643ccabb32285c74d6bff5.tar.xz ipxe-cc07ed7c7ede8dfc79643ccabb32285c74d6bff5.zip | |
[console] Avoid overlap between remapping flags and character values
The keyboard remapping flags currently occupy bits 8 and upwards of
the to-be-mapped character value. This overlaps the range used for
special keys (KEY_MIN and upwards) and also overlaps the valid Unicode
character range.
No conflict is created by this overlap, since by design only ASCII
character values (as generated by an ASCII-only keyboard driver) are
subject to remapping, and so the to-be-remapped character values exist
in a conceptually separate namespace from either special keys or
non-ASCII Unicode characters. However, the overlap is potentially
confusing for readers of the code.
Minimise cognitive load by using bits 24 and upwards for the keyboard
remapping flags.
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/image')
0 files changed, 0 insertions, 0 deletions