summaryrefslogtreecommitdiffstats
path: root/src/include/gpxe/ib_gma.h
diff options
context:
space:
mode:
authorMichael Brown2009-07-10 22:29:25 +0200
committerMichael Brown2009-07-18 00:06:35 +0200
commit94876f4bb69cec4503a6aa4783b0a5822845e1a4 (patch)
treecb0ebb7caf7ed62132f79fbcb5c2ef72480a6b8d /src/include/gpxe/ib_gma.h
parent[infiniband] Allow external QPN to differ from real QPN (diff)
downloadipxe-94876f4bb69cec4503a6aa4783b0a5822845e1a4.tar.gz
ipxe-94876f4bb69cec4503a6aa4783b0a5822845e1a4.tar.xz
ipxe-94876f4bb69cec4503a6aa4783b0a5822845e1a4.zip
[infiniband] Remove the return status code from MAD handlers
MAD handlers have to set the status fields within the MAD itself anyway, in order to provide a meaningful response MAD; the additional gPXE return status code is just noise. Note that we probably don't need to ever explicitly set the status to IB_MGMT_STATUS_OK, since it should already have this value from the request. (By not explicitly setting the status in this way, we can safely have ib_sma_set_xxx() call ib_sma_get_xxx() in order to generate the GetResponse MAD without worrying that ib_sma_get_xxx() will clear any error status set by ib_sma_set_xxx().)
Diffstat (limited to 'src/include/gpxe/ib_gma.h')
-rw-r--r--src/include/gpxe/ib_gma.h3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/include/gpxe/ib_gma.h b/src/include/gpxe/ib_gma.h
index 4764a6cc..c549dfcb 100644
--- a/src/include/gpxe/ib_gma.h
+++ b/src/include/gpxe/ib_gma.h
@@ -34,13 +34,12 @@ struct ib_gma_handler {
*
* @v gma General management agent
* @v mad MAD
- * @ret rc Return status code
*
* The handler should modify the MAD as applicable. If the
* handler returns with a non-zero value in the MAD's @c
* method field, it will be sent as a response.
*/
- int ( * handle ) ( struct ib_gma *gma, union ib_mad *mad );
+ void ( * handle ) ( struct ib_gma *gma, union ib_mad *mad );
};
/** GMA attribute handlers */