diff options
| author | Michael Brown | 2025-03-23 19:22:00 +0100 |
|---|---|---|
| committer | Michael Brown | 2025-03-23 19:24:10 +0100 |
| commit | 331bbf50755bb0ba5405dfd8e4350cfc3684bc09 (patch) | |
| tree | f2292c0dc5a3f1bbd833c6373222b428c576277b /src/interface/efi | |
| parent | [efi] Use driver name only from driver binding handles in debug messages (diff) | |
| download | ipxe-331bbf50755bb0ba5405dfd8e4350cfc3684bc09.tar.gz ipxe-331bbf50755bb0ba5405dfd8e4350cfc3684bc09.tar.xz ipxe-331bbf50755bb0ba5405dfd8e4350cfc3684bc09.zip | |
[efi] Remove spurious close of SNP device parent's device path
Commit e727f57 ("[efi] Include a copy of the device path within struct
efi_device") neglected to delete the closure of the parent's device
path from the success code path in efi_snp_probe().
Reduce confusion by removing this (harmless) additional close.
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/interface/efi')
| -rw-r--r-- | src/interface/efi/efi_snp.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/interface/efi/efi_snp.c b/src/interface/efi/efi_snp.c index 8443be997..d977802fd 100644 --- a/src/interface/efi/efi_snp.c +++ b/src/interface/efi/efi_snp.c @@ -1958,10 +1958,6 @@ static int efi_snp_probe ( struct net_device *netdev, void *priv __unused ) { /* Add to list of SNP devices */ list_add ( &snpdev->list, &efi_snp_devices ); - /* Close device path */ - bs->CloseProtocol ( efidev->device, &efi_device_path_protocol_guid, - efi_image_handle, efidev->device ); - DBGC ( snpdev, "SNPDEV %p installed for %s as device %s\n", snpdev, netdev->name, efi_handle_name ( snpdev->handle ) ); return 0; |