From 9de525c34cad0252fe6ff823ee7e18240e472298 Mon Sep 17 00:00:00 2001 From: Shao Miller Date: Thu, 22 Oct 2009 17:00:24 -0400 Subject: [dhcp] Ensure message type is first DHCP option Apparently, the DHCP relay logic on a Nortel 470-48T layer 2 switch cares about the order of DHCP options. Specifically, it requires that the DHCP message type option be the first option present in the DHCP packet. We achieve this by having this option appear first in our dhcp_request_options_data array, which pre-populates DHCP requests. Signed-off-by: Marty Connor --- src/net/udp/dhcp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/net/udp/dhcp.c b/src/net/udp/dhcp.c index 17e543ac..b0dd9529 100644 --- a/src/net/udp/dhcp.c +++ b/src/net/udp/dhcp.c @@ -71,6 +71,7 @@ static const uint8_t dhcp_op[] = { /** Raw option data for options common to all DHCP requests */ static uint8_t dhcp_request_options_data[] = { + DHCP_MESSAGE_TYPE, DHCP_BYTE ( 0 ), DHCP_MAX_MESSAGE_SIZE, DHCP_WORD ( ETH_MAX_MTU - 20 /* IP header */ - 8 /* UDP header */ ), DHCP_CLIENT_ARCHITECTURE, DHCP_WORD ( 0 ), -- cgit v1.2.3-55-g7522