From a5c41483d226a6c4dbfaf35f57dc092cd57bc601 Mon Sep 17 00:00:00 2001 From: Michael Brown Date: Sat, 17 Aug 2019 17:18:54 +0100 Subject: [coverity] Override assumptions about wcrtomb() and hmac_init() Newer versions of Coverity use built-in models for wcrtomb() and hmac_init() that are capable of returning errors, and reports defects due to code failing to check for these errors. The actual iPXE implementations are simpler than Coverity's models and can never return errors, so these defects are false positives. Fix by overriding Coverity's built-in models for these functions. Signed-off-by: Michael Brown --- contrib/coverity/model.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/contrib/coverity/model.c b/contrib/coverity/model.c index 15535d42..43bac58d 100644 --- a/contrib/coverity/model.c +++ b/contrib/coverity/model.c @@ -7,6 +7,9 @@ typedef long off_t; typedef void * userptr_t; typedef long long time_t; struct tm; +typedef unsigned short wchar_t; +typedef void mbstate_t; +struct digest_algorithm; /* Inhibit use of built-in models for functions where Coverity's * assumptions about the modelled function are incorrect for iPXE. @@ -19,3 +22,8 @@ time_t mktime ( struct tm *tm ) { } int getchar ( void ) { } +size_t wcrtomb ( char *buf, wchar_t wc, mbstate_t *ps ) { +} +void hmac_init ( struct digest_algorithm *digest, void *digest_ctx, + void *key, size_t *key_len ) { +} -- cgit v1.2.3-55-g7522