From b6f9e4bab082c3b7a9b587ef64109069fba59baa Mon Sep 17 00:00:00 2001
From: Michael Brown
Date: Wed, 30 Apr 2025 15:18:34 +0100
Subject: [uaccess] Remove redundant copy_from_user() and copy_to_user()

Remove the now-redundant copy_from_user() and copy_to_user() wrapper
functions.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
---
 src/drivers/bus/devtree.c                                       | 1 +
 src/drivers/bus/ecam.c                                          | 1 +
 src/drivers/bus/pci_settings.c                                  | 1 +
 src/drivers/bus/usb_settings.c                                  | 1 +
 src/drivers/infiniband/flexboot_nodnic.c                        | 1 +
 src/drivers/infiniband/linda.c                                  | 1 +
 src/drivers/infiniband/mlx_utils_flexboot/src/mlx_memory_priv.c | 1 +
 src/drivers/infiniband/qib7322.c                                | 1 +
 src/drivers/linux/slirp.c                                       | 1 +
 src/drivers/net/ath/ath.h                                       | 1 +
 src/drivers/net/ath/ath5k/ath5k.h                               | 1 +
 src/drivers/net/b44.c                                           | 1 +
 src/drivers/net/bnxt/bnxt.c                                     | 1 +
 src/drivers/net/eepro100.c                                      | 1 +
 src/drivers/net/etherfabric.c                                   | 1 +
 src/drivers/net/marvell/atl2_hw.c                               | 1 +
 src/drivers/net/marvell/atl_hw.c                                | 1 +
 src/drivers/net/myri10ge.c                                      | 2 +-
 src/drivers/net/netvsc.c                                        | 1 +
 src/drivers/net/rtl818x/rtl818x.c                               | 1 +
 src/drivers/net/sfc/efx_hunt.c                                  | 1 +
 src/drivers/net/sfc/sfc_hunt.c                                  | 1 +
 src/drivers/net/skge.c                                          | 1 +
 src/drivers/net/sky2.c                                          | 1 +
 src/drivers/net/tg3/tg3.c                                       | 1 +
 src/drivers/net/tg3/tg3_hw.c                                    | 1 +
 src/drivers/net/tg3/tg3_phy.c                                   | 1 +
 src/drivers/net/vmxnet3.c                                       | 1 +
 src/drivers/net/vxge/vxge_config.c                              | 1 +
 src/drivers/net/vxge/vxge_traffic.c                             | 1 +
 src/drivers/nvs/nvsvpd.c                                        | 1 +
 src/drivers/usb/usbblk.c                                        | 1 +
 32 files changed, 32 insertions(+), 1 deletion(-)

(limited to 'src/drivers')

diff --git a/src/drivers/bus/devtree.c b/src/drivers/bus/devtree.c
index cbd8ea8fa..654f8d14f 100644
--- a/src/drivers/bus/devtree.c
+++ b/src/drivers/bus/devtree.c
@@ -31,6 +31,7 @@ FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL );
 
 #include <stdlib.h>
 #include <stdio.h>
+#include <string.h>
 #include <errno.h>
 #include <ipxe/device.h>
 #include <ipxe/fdt.h>
diff --git a/src/drivers/bus/ecam.c b/src/drivers/bus/ecam.c
index 58d513e88..35556a8d9 100644
--- a/src/drivers/bus/ecam.c
+++ b/src/drivers/bus/ecam.c
@@ -23,6 +23,7 @@
 
 FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL );
 
+#include <string.h>
 #include <errno.h>
 #include <ipxe/uaccess.h>
 #include <ipxe/ecam.h>
diff --git a/src/drivers/bus/pci_settings.c b/src/drivers/bus/pci_settings.c
index 98005559d..84aa76827 100644
--- a/src/drivers/bus/pci_settings.c
+++ b/src/drivers/bus/pci_settings.c
@@ -24,6 +24,7 @@
 FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL );
 
 #include <stdio.h>
+#include <string.h>
 #include <errno.h>
 #include <ipxe/pci.h>
 #include <ipxe/settings.h>
diff --git a/src/drivers/bus/usb_settings.c b/src/drivers/bus/usb_settings.c
index db6f94d8a..4fd190d83 100644
--- a/src/drivers/bus/usb_settings.c
+++ b/src/drivers/bus/usb_settings.c
@@ -24,6 +24,7 @@
 FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL );
 
 #include <stdio.h>
+#include <string.h>
 #include <errno.h>
 #include <ipxe/usb.h>
 #include <ipxe/settings.h>
diff --git a/src/drivers/infiniband/flexboot_nodnic.c b/src/drivers/infiniband/flexboot_nodnic.c
index c6e19b955..a9e6fdd71 100644
--- a/src/drivers/infiniband/flexboot_nodnic.c
+++ b/src/drivers/infiniband/flexboot_nodnic.c
@@ -20,6 +20,7 @@
 FILE_LICENCE ( GPL2_OR_LATER );
 
 #include <stdio.h>
+#include <string.h>
 #include <unistd.h>
 #include <errno.h>
 #include <ipxe/pci.h>
diff --git a/src/drivers/infiniband/linda.c b/src/drivers/infiniband/linda.c
index 0c8a043a1..2e2b469e4 100644
--- a/src/drivers/infiniband/linda.c
+++ b/src/drivers/infiniband/linda.c
@@ -25,6 +25,7 @@ FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL );
 
 #include <stdint.h>
 #include <stdlib.h>
+#include <string.h>
 #include <errno.h>
 #include <unistd.h>
 #include <assert.h>
diff --git a/src/drivers/infiniband/mlx_utils_flexboot/src/mlx_memory_priv.c b/src/drivers/infiniband/mlx_utils_flexboot/src/mlx_memory_priv.c
index e368d459b..b35c30dee 100644
--- a/src/drivers/infiniband/mlx_utils_flexboot/src/mlx_memory_priv.c
+++ b/src/drivers/infiniband/mlx_utils_flexboot/src/mlx_memory_priv.c
@@ -7,6 +7,7 @@
 
 #include <ipxe/malloc.h>
 #include <stddef.h>
+#include <string.h>
 #include <byteswap.h>
 #include <ipxe/io.h>
 #include "../../mlx_utils/include/private/mlx_memory_priv.h"
diff --git a/src/drivers/infiniband/qib7322.c b/src/drivers/infiniband/qib7322.c
index a011dafc1..a9e4566dc 100644
--- a/src/drivers/infiniband/qib7322.c
+++ b/src/drivers/infiniband/qib7322.c
@@ -25,6 +25,7 @@ FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL );
 
 #include <stdint.h>
 #include <stdlib.h>
+#include <string.h>
 #include <errno.h>
 #include <unistd.h>
 #include <assert.h>
diff --git a/src/drivers/linux/slirp.c b/src/drivers/linux/slirp.c
index 8341c9676..d7ab6419e 100644
--- a/src/drivers/linux/slirp.c
+++ b/src/drivers/linux/slirp.c
@@ -18,6 +18,7 @@
  */
 
 #include <stdio.h>
+#include <string.h>
 #include <errno.h>
 #include <ipxe/netdevice.h>
 #include <ipxe/ethernet.h>
diff --git a/src/drivers/net/ath/ath.h b/src/drivers/net/ath/ath.h
index 589bb5634..21f795b70 100644
--- a/src/drivers/net/ath/ath.h
+++ b/src/drivers/net/ath/ath.h
@@ -23,6 +23,7 @@
 FILE_LICENCE ( BSD2 );
 
 #include <unistd.h>
+#include <string.h>
 #include <ipxe/net80211.h>
 
 /* This block of functions are from kernel.h v3.0.1 */
diff --git a/src/drivers/net/ath/ath5k/ath5k.h b/src/drivers/net/ath/ath5k/ath5k.h
index fa62e8ce5..727d41279 100644
--- a/src/drivers/net/ath/ath5k/ath5k.h
+++ b/src/drivers/net/ath/ath5k/ath5k.h
@@ -24,6 +24,7 @@
 FILE_LICENCE ( MIT );
 
 #include <stddef.h>
+#include <string.h>
 #include <byteswap.h>
 #include <ipxe/io.h>
 #include <ipxe/netdevice.h>
diff --git a/src/drivers/net/b44.c b/src/drivers/net/b44.c
index 30ece5574..c6ca99865 100644
--- a/src/drivers/net/b44.c
+++ b/src/drivers/net/b44.c
@@ -31,6 +31,7 @@
 
 FILE_LICENCE ( GPL2_OR_LATER );
 
+#include <string.h>
 #include <errno.h>
 #include <assert.h>
 #include <stdio.h>
diff --git a/src/drivers/net/bnxt/bnxt.c b/src/drivers/net/bnxt/bnxt.c
index 5de8d094e..402439eef 100644
--- a/src/drivers/net/bnxt/bnxt.c
+++ b/src/drivers/net/bnxt/bnxt.c
@@ -3,6 +3,7 @@ FILE_LICENCE ( GPL2_ONLY );
 
 #include <mii.h>
 #include <stdio.h>
+#include <string.h>
 #include <errno.h>
 #include <unistd.h>
 #include <byteswap.h>
diff --git a/src/drivers/net/eepro100.c b/src/drivers/net/eepro100.c
index 49b00d443..318db1883 100644
--- a/src/drivers/net/eepro100.c
+++ b/src/drivers/net/eepro100.c
@@ -101,6 +101,7 @@ FILE_LICENCE ( GPL2_OR_LATER );
  */
 
 #include <stdint.h>
+#include <string.h>
 #include <byteswap.h>
 #include <errno.h>
 #include <stdio.h>
diff --git a/src/drivers/net/etherfabric.c b/src/drivers/net/etherfabric.c
index be30b71f7..a58b71568 100644
--- a/src/drivers/net/etherfabric.c
+++ b/src/drivers/net/etherfabric.c
@@ -21,6 +21,7 @@ FILE_LICENCE ( GPL_ANY );
 #include <stdint.h>
 #include <stdlib.h>
 #include <stdio.h>
+#include <string.h>
 #include <unistd.h>
 #include <errno.h>
 #include <assert.h>
diff --git a/src/drivers/net/marvell/atl2_hw.c b/src/drivers/net/marvell/atl2_hw.c
index 805820709..07822a9c2 100644
--- a/src/drivers/net/marvell/atl2_hw.c
+++ b/src/drivers/net/marvell/atl2_hw.c
@@ -31,6 +31,7 @@
 
 FILE_LICENCE ( BSD2 );
 
+#include <string.h>
 #include <errno.h>
 #include <stdio.h>
 #include <unistd.h>
diff --git a/src/drivers/net/marvell/atl_hw.c b/src/drivers/net/marvell/atl_hw.c
index e0843e6f4..fa7f2a9b8 100644
--- a/src/drivers/net/marvell/atl_hw.c
+++ b/src/drivers/net/marvell/atl_hw.c
@@ -31,6 +31,7 @@
 
 FILE_LICENCE ( BSD2 );
 
+#include <string.h>
 #include <errno.h>
 #include <stdio.h>
 #include <unistd.h>
diff --git a/src/drivers/net/myri10ge.c b/src/drivers/net/myri10ge.c
index 6d0f723f2..fb9dc01b2 100644
--- a/src/drivers/net/myri10ge.c
+++ b/src/drivers/net/myri10ge.c
@@ -74,7 +74,7 @@ FILE_LICENCE ( GPL2_ONLY );
  */
 
 #include <stdint.h>
-
+#include <string.h>
 #include <byteswap.h>
 #include <errno.h>
 #include <ipxe/ethernet.h>
diff --git a/src/drivers/net/netvsc.c b/src/drivers/net/netvsc.c
index 4bdf7b517..9b6ee88b4 100644
--- a/src/drivers/net/netvsc.c
+++ b/src/drivers/net/netvsc.c
@@ -32,6 +32,7 @@ FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL );
  * bus (VMBus).  It provides a transport layer for RNDIS packets.
  */
 
+#include <string.h>
 #include <errno.h>
 #include <unistd.h>
 #include <byteswap.h>
diff --git a/src/drivers/net/rtl818x/rtl818x.c b/src/drivers/net/rtl818x/rtl818x.c
index 599d36fad..3bae8a797 100644
--- a/src/drivers/net/rtl818x/rtl818x.c
+++ b/src/drivers/net/rtl818x/rtl818x.c
@@ -20,6 +20,7 @@
 FILE_LICENCE(GPL2_ONLY);
 
 #include <stdint.h>
+#include <string.h>
 #include <errno.h>
 #include <stdio.h>
 #include <unistd.h>
diff --git a/src/drivers/net/sfc/efx_hunt.c b/src/drivers/net/sfc/efx_hunt.c
index abe3e8320..92c0fda62 100644
--- a/src/drivers/net/sfc/efx_hunt.c
+++ b/src/drivers/net/sfc/efx_hunt.c
@@ -21,6 +21,7 @@
 #include <stdint.h>
 #include <stdlib.h>
 #include <stdio.h>
+#include <string.h>
 #include <unistd.h>
 #include <errno.h>
 #include <assert.h>
diff --git a/src/drivers/net/sfc/sfc_hunt.c b/src/drivers/net/sfc/sfc_hunt.c
index 43ac229ab..f763fc9d0 100644
--- a/src/drivers/net/sfc/sfc_hunt.c
+++ b/src/drivers/net/sfc/sfc_hunt.c
@@ -19,6 +19,7 @@
  ***************************************************************************/
 #include <stdlib.h>
 #include <stdio.h>
+#include <string.h>
 #include <unistd.h>
 #include <errno.h>
 #include <byteswap.h>
diff --git a/src/drivers/net/skge.c b/src/drivers/net/skge.c
index cc7f0b91b..828a2a4c9 100755
--- a/src/drivers/net/skge.c
+++ b/src/drivers/net/skge.c
@@ -31,6 +31,7 @@
 FILE_LICENCE ( GPL2_ONLY );
 
 #include <stdint.h>
+#include <string.h>
 #include <errno.h>
 #include <stdio.h>
 #include <unistd.h>
diff --git a/src/drivers/net/sky2.c b/src/drivers/net/sky2.c
index 4f8ec3e42..db3f6aaa1 100644
--- a/src/drivers/net/sky2.c
+++ b/src/drivers/net/sky2.c
@@ -28,6 +28,7 @@
 FILE_LICENCE ( GPL2_ONLY );
 
 #include <stdint.h>
+#include <string.h>
 #include <errno.h>
 #include <stdio.h>
 #include <unistd.h>
diff --git a/src/drivers/net/tg3/tg3.c b/src/drivers/net/tg3/tg3.c
index 05af22d61..a6736305c 100644
--- a/src/drivers/net/tg3/tg3.c
+++ b/src/drivers/net/tg3/tg3.c
@@ -3,6 +3,7 @@ FILE_LICENCE ( GPL2_ONLY );
 
 #include <mii.h>
 #include <stdio.h>
+#include <string.h>
 #include <errno.h>
 #include <unistd.h>
 #include <byteswap.h>
diff --git a/src/drivers/net/tg3/tg3_hw.c b/src/drivers/net/tg3/tg3_hw.c
index 9a70413b6..5c9506dce 100644
--- a/src/drivers/net/tg3/tg3_hw.c
+++ b/src/drivers/net/tg3/tg3_hw.c
@@ -18,6 +18,7 @@
 FILE_LICENCE ( GPL2_ONLY );
 
 #include <mii.h>
+#include <string.h>
 #include <stdio.h>
 #include <errno.h>
 #include <unistd.h>
diff --git a/src/drivers/net/tg3/tg3_phy.c b/src/drivers/net/tg3/tg3_phy.c
index e88b0be0f..a2322329e 100644
--- a/src/drivers/net/tg3/tg3_phy.c
+++ b/src/drivers/net/tg3/tg3_phy.c
@@ -1,6 +1,7 @@
 
 #include <mii.h>
 #include <stdio.h>
+#include <string.h>
 #include <errno.h>
 #include <unistd.h>
 #include <byteswap.h>
diff --git a/src/drivers/net/vmxnet3.c b/src/drivers/net/vmxnet3.c
index 3800d6b72..2cc6738f2 100644
--- a/src/drivers/net/vmxnet3.c
+++ b/src/drivers/net/vmxnet3.c
@@ -24,6 +24,7 @@
 FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL );
 
 #include <stdint.h>
+#include <string.h>
 #include <errno.h>
 #include <assert.h>
 #include <byteswap.h>
diff --git a/src/drivers/net/vxge/vxge_config.c b/src/drivers/net/vxge/vxge_config.c
index f4d217097..8c6ee9e96 100644
--- a/src/drivers/net/vxge/vxge_config.c
+++ b/src/drivers/net/vxge/vxge_config.c
@@ -16,6 +16,7 @@ FILE_LICENCE(GPL2_ONLY);
 
 #include <stdlib.h>
 #include <stdio.h>
+#include <string.h>
 #include <ipxe/malloc.h>
 #include <ipxe/pci.h>
 #include <ipxe/iobuf.h>
diff --git a/src/drivers/net/vxge/vxge_traffic.c b/src/drivers/net/vxge/vxge_traffic.c
index dbd799015..0adaea2aa 100644
--- a/src/drivers/net/vxge/vxge_traffic.c
+++ b/src/drivers/net/vxge/vxge_traffic.c
@@ -15,6 +15,7 @@
 FILE_LICENCE(GPL2_ONLY);
 
 #include <ipxe/netdevice.h>
+#include <string.h>
 #include <errno.h>
 
 #include "vxge_traffic.h"
diff --git a/src/drivers/nvs/nvsvpd.c b/src/drivers/nvs/nvsvpd.c
index 3e88531c7..195973319 100644
--- a/src/drivers/nvs/nvsvpd.c
+++ b/src/drivers/nvs/nvsvpd.c
@@ -24,6 +24,7 @@
 FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL );
 
 #include <stdio.h>
+#include <string.h>
 #include <errno.h>
 #include <ipxe/nvs.h>
 #include <ipxe/pci.h>
diff --git a/src/drivers/usb/usbblk.c b/src/drivers/usb/usbblk.c
index 39adc012f..cb377efb0 100644
--- a/src/drivers/usb/usbblk.c
+++ b/src/drivers/usb/usbblk.c
@@ -25,6 +25,7 @@ FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL );
 
 #include <stdint.h>
 #include <stdlib.h>
+#include <string.h>
 #include <errno.h>
 #include <ipxe/usb.h>
 #include <ipxe/scsi.h>
-- 
cgit v1.2.3-55-g7522