From 4a480f1d1565aa5972c4fc27ceec8ae4b9b1e86c Mon Sep 17 00:00:00 2001 From: Michael Brown Date: Thu, 31 Jul 2014 12:22:40 +0100 Subject: [efi] Avoid unnecessarily passing pointers to EFI_HANDLEs efi_file_install() and efi_download_install() are both used to install onto existing handles. There is therefore no need to allow for each of their calls to InstallMultipleProtocolInterfaces() to create a new handle. By passing the handle directly (rather than a pointer to the handle), we avoid potential confusion (and erroneous debug message colours). Signed-off-by: Michael Brown --- src/image/efi_image.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/image') diff --git a/src/image/efi_image.c b/src/image/efi_image.c index 02ff8b2f..45a68e53 100644 --- a/src/image/efi_image.c +++ b/src/image/efi_image.c @@ -157,14 +157,14 @@ static int efi_image_exec ( struct image *image ) { } /* Install file I/O protocols */ - if ( ( rc = efi_file_install ( &snpdev->handle ) ) != 0 ) { + if ( ( rc = efi_file_install ( snpdev->handle ) ) != 0 ) { DBGC ( image, "EFIIMAGE %p could not install file protocol: " "%s\n", image, strerror ( rc ) ); goto err_file_install; } /* Install iPXE download protocol */ - if ( ( rc = efi_download_install ( &snpdev->handle ) ) != 0 ) { + if ( ( rc = efi_download_install ( snpdev->handle ) ) != 0 ) { DBGC ( image, "EFIIMAGE %p could not install iPXE download " "protocol: %s\n", image, strerror ( rc ) ); goto err_download_install; -- cgit v1.2.3-55-g7522