From 4a480f1d1565aa5972c4fc27ceec8ae4b9b1e86c Mon Sep 17 00:00:00 2001 From: Michael Brown Date: Thu, 31 Jul 2014 12:22:40 +0100 Subject: [efi] Avoid unnecessarily passing pointers to EFI_HANDLEs efi_file_install() and efi_download_install() are both used to install onto existing handles. There is therefore no need to allow for each of their calls to InstallMultipleProtocolInterfaces() to create a new handle. By passing the handle directly (rather than a pointer to the handle), we avoid potential confusion (and erroneous debug message colours). Signed-off-by: Michael Brown --- src/include/ipxe/efi/efi_download.h | 4 ++-- src/include/ipxe/efi/efi_file.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/include/ipxe/efi') diff --git a/src/include/ipxe/efi/efi_download.h b/src/include/ipxe/efi/efi_download.h index 3ce497221..740fcadf5 100644 --- a/src/include/ipxe/efi/efi_download.h +++ b/src/include/ipxe/efi/efi_download.h @@ -151,7 +151,7 @@ struct _IPXE_DOWNLOAD_PROTOCOL { 0x3eaeaebd, 0xdecf, 0x493b, { 0x9b, 0xd1, 0xcd, 0xb2, 0xde, 0xca, 0xe7, 0x19 } \ } -extern int efi_download_install ( EFI_HANDLE *device ); -extern void efi_download_uninstall ( EFI_HANDLE device ); +extern int efi_download_install ( EFI_HANDLE handle ); +extern void efi_download_uninstall ( EFI_HANDLE handle ); #endif /* _IPXE_DOWNLOAD_H */ diff --git a/src/include/ipxe/efi/efi_file.h b/src/include/ipxe/efi/efi_file.h index 0d75cf5b0..e4db0305a 100644 --- a/src/include/ipxe/efi/efi_file.h +++ b/src/include/ipxe/efi/efi_file.h @@ -7,7 +7,7 @@ * */ -extern int efi_file_install ( EFI_HANDLE *handle ); +extern int efi_file_install ( EFI_HANDLE handle ); extern void efi_file_uninstall ( EFI_HANDLE handle ); #endif /* _IPXE_EFI_FILE_H */ -- cgit v1.2.3-55-g7522