From 2aad3fab233f0235f9a8f677ae7bb402f1647eb6 Mon Sep 17 00:00:00 2001 From: Joshua Oreman Date: Wed, 26 May 2010 17:52:44 -0700 Subject: [build] Use weak definitions instead of weak declarations This removes the need for inline safety wrappers, marginally reducing the size penalty of weak functions, and works around an apparent binutils bug that causes undefined weak symbols to not actually be NULL when compiling with -fPIE (as EFI builds do). A bug in versions of binutils prior to 2.16 (released in 2005) will cause same-file weak definitions to not work with those toolchains. Update the README to reflect our new dependency on binutils >= 2.16. Signed-off-by: Joshua Oreman Signed-off-by: Michael Brown --- src/include/usr/autoboot.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/include/usr') diff --git a/src/include/usr/autoboot.h b/src/include/usr/autoboot.h index 70c1adfc9..81b686b54 100644 --- a/src/include/usr/autoboot.h +++ b/src/include/usr/autoboot.h @@ -19,7 +19,6 @@ extern int boot_next_server_and_filename ( struct in_addr next_server, const char *filename ); extern int boot_root_path ( const char *root_path ); -extern int pxe_menu_boot ( struct net_device *netdev ) - __attribute__ (( weak )); +extern int pxe_menu_boot ( struct net_device *netdev ); #endif /* _USR_AUTOBOOT_H */ -- cgit v1.2.3-55-g7522