From b20d4a1522646f71ec22b541d95f9d603760a58d Mon Sep 17 00:00:00 2001 From: Michael Brown Date: Tue, 28 Jul 2015 15:05:44 +0100 Subject: [netdevice] Allow network devices to disclaim IRQ support at runtime VLAN and 802.11 devices use a network device operations structure that wraps an underlying structure. For example, the vlan_operations structure wraps the network device operations structure of the underlying trunk device. This can cause false positives from the current implementation of netdev_irq_supported(), which will always report that VLAN devices support interrupts since it has no visibility into the support provided by the underlying trunk device. Fix by allowing network devices to explicitly flag that interrupts are not supported, despite the presence of an irq() method. Originally-fixed-by: Wissam Shoukair Signed-off-by: Michael Brown --- src/net/vlan.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/net/vlan.c') diff --git a/src/net/vlan.c b/src/net/vlan.c index 49e3257a..f515c2dc 100644 --- a/src/net/vlan.c +++ b/src/net/vlan.c @@ -389,6 +389,10 @@ int vlan_create ( struct net_device *trunk, unsigned int tag, snprintf ( netdev->name, sizeof ( netdev->name ), "%s-%d", trunk->name, vlan->tag ); + /* Mark device as not supporting interrupts, if applicable */ + if ( ! netdev_irq_supported ( trunk ) ) + netdev->state |= NETDEV_IRQ_UNSUPPORTED; + /* Register VLAN device */ if ( ( rc = register_netdev ( netdev ) ) != 0 ) { DBGC ( netdev, "VLAN %s could not register: %s\n", -- cgit v1.2.3-55-g7522