From e5d9d9262ba5d9434891945de63f1eae66badabe Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Wed, 7 Jul 2021 17:28:24 +0200
Subject: setup_target: Install all required packages at once at the start

If we can't satisfy the requirements of all modules, bail out early
instead of some time halfway through the module list. This is also
faster than invoking apt for every single package.
---
 core/bin/setup_target | 48 ++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 42 insertions(+), 6 deletions(-)

(limited to 'core/bin')

diff --git a/core/bin/setup_target b/core/bin/setup_target
index 04417efd..ebb8218e 100755
--- a/core/bin/setup_target
+++ b/core/bin/setup_target
@@ -63,14 +63,52 @@ initial_checks () {
 	detect_distribution
 }
 
+unset_required_vars () {
+	for VARNAME in ${!REQUIRED_*}; do
+		unset $VARNAME
+	done
+}
+
+# Install all the packages from all selected modules in current target
+install_all_packages () {
+	local module file config
+	declare -A packages dupcheck
+	packages=()
+	for module in "${!MODULE_PATHS[@]}"; do
+		unset_required_vars
+		config="${MODULE_PATHS["$module"]}/module.conf"
+		for file in $SYS_VERSIONS; do
+			if [ -e "${config}.${file}" ]; then
+				validate_config "${config}.${file}"
+				. "${config}.${file}"
+				break
+			fi
+		done
+		dupcheck=()
+		for file in $REQUIRED_INSTALLED_PACKAGES; do
+			[ -n "${dupcheck["$file"]}" ] && continue
+			packages["$file"]+=" $module"
+			dupcheck["$file"]=1
+		done
+		for file in $REQUIRED_CONTENT_PACKAGES; do
+			[ "${file:0:1}" = "@" ] && continue
+			[ -n "${dupcheck["$file"]}" ] && continue
+			packages["$file"]+=" $module"
+			dupcheck["$file"]=1
+		done
+	done
+	pinfo "Making sure required packages are installed..."
+	pdebug "List: ${!packages[*]}"
+	install_packages "${!packages[@]}"
+	unset_required_vars
+}
+
 #
 # generic function to read the config file of the current $MODULE
 #
 read_config () {
 	# unset previous variables from other config files
-	for VARNAME in ${!REQUIRED_*}; do
-		unset $VARNAME
-	done
+	unset_required_vars
 
 	local MODULE_CONFIG="${MODULE_DIR}/module.conf"
 
@@ -313,6 +351,7 @@ generate_target() {
 	shift
 	TARGET_DIR="$( readlink -f "${TARGETS_BASEDIR}/${TARGET}" )"
 	scan_target "$TARGET_DIR"
+	install_all_packages
 	if [[ "$TARGET" == *@* ]]; then
 		VARNAME="${TARGET#*@}"
 		TARGET="${TARGET%@*}"
@@ -451,10 +490,7 @@ process_module() {
 	pdebug "## Reading .build of $MODULE"
 	. "${CORE_DIR}/includes/clean_module_funcs.inc" # Clean all hooks, in case the module doesn't define them all
 	read_build # Read all the hooks from the module
-	# Install module's dependencies
-	pdebug "## Installing dependencies"
 	cd "${MODULE_DIR}" || perror "cd to '${MODULE_DIR}' failed."
-	install_dependencies
 	# update kernel version variables before running a module, as the last one might have been the kernel...
 	get_kernel_version
 	# Execute load-hook before anything else
-- 
cgit v1.2.3-55-g7522