openslx-ng/slx-admin.git/modules-available/permissionmanager/inc/permissionutil.inc.php, branch masterWeb Interface zum Verwalten der Hochschul-/UniSpezifischen Einstellungen der Linux-Umgebunghttps://git.openslx.org/openslx-ng/slx-admin.git/atom/modules-available/permissionmanager/inc/permissionutil.inc.php?h=master2025-12-12T14:16:59+00:00Add tests using PHPUnit2025-12-12T14:16:59+00:00Simon Rettberg2025-11-26T09:46:51+00:00urn:sha1:7c173411785f959d250d3dfbd7d4cfcb0e20f0e0
Tests generated by Junie AI. Might not have the best possible quality
but at least we got something, and if it turns out to be complete
rubbish, we can just throw it out again without any issues, as this is
independent of the actual code base.
[locations] Cleanup Location class2025-07-07T11:37:19+00:00Simon Rettberg2025-07-07T11:37:19+00:00urn:sha1:9a5106c288519b008e0dfe5e85371701af32c0f3
There was a mess of functions which mostly, but not quite, did the same
things. Get rid of a couple of them and fix call sites to use
alternative ones that also fit the job.
While at it, add phpdoc and comments to the remaining functions, trying
to clarify what they were designed for.
Lastly, the return type of functions that retrieve a location id has
been changed from false|int to ?int (nullable types are just nicer).
Add function param/return types, fix a lot more phpstorm complaints2023-11-14T13:47:55+00:00Simon Rettberg2023-11-14T13:47:55+00:00urn:sha1:06bff0b9b84d47c43f9bc8aff06a29d85ebb7ed0Roundup of issues reported by PHPStorm2023-11-02T18:08:58+00:00Simon Rettberg2023-11-02T18:08:58+00:00urn:sha1:c2d95ffaeaa289752b4c7b6664b6ca112a02e350
Mostly redundant checks, logic errors, dead code, etc.
[permissionmanager] Fix for PHP 82022-03-09T14:06:54+00:00Simon Rettberg2021-11-29T15:14:26+00:00urn:sha1:462c0c2b4402cded7e321a7f57e864f40690e425Moderize Database handling2021-05-11T12:51:13+00:00Simon Rettberg2021-05-06T08:26:09+00:00urn:sha1:8dc2b92d667f1401ab9f1315a36add61658f899c
* Auto-convert to utf8mb4_unicode_520_ci
* Use foreach instead of while to loop over results
* Drop useless statement caching
* Keep emulated prepares, as we sometimes loop over nested queries
[permissionmanager] Fix creating bogus negative cache entries2019-11-05T16:38:04+00:00Simon Rettberg2019-11-05T16:38:04+00:00urn:sha1:ddab79e04bc4ffec86946f77e0995b56fd4b0052
If a permission check for a location yielded false, a cache entry for
all parent locations with value "false" was created as well.
[permissionmanager] Implement caching for permission checks2019-08-01T11:59:31+00:00Simon Rettberg2019-08-01T11:59:31+00:00urn:sha1:82aa18343f116c5baf38408b876f00edfe99514d
Some pages, like the location list, triggered excessive amounts of DB
queries when checking permissions. In that specific case, the number of
queries got cut down from 260 to 24, and the page generation time
dropped from 150ms to 80ms. (On a setup with 62 locations)
[adduser] Support setting user's roles on add/edit2018-02-23T17:41:49+00:00Simon Rettberg2018-02-23T17:41:49+00:00urn:sha1:00851bd25e57938a79356d2efb36c2bea1697760[permissionmanager] Ensure uniqueness in role_x_location table, consistent table naming, drop unused id field2018-02-20T14:20:26+00:00Simon Rettberg2018-02-20T14:20:26+00:00urn:sha1:7dc7a49e3704b52c4a40909050bf831826b3c41b