openslx-ng/slx-admin.git/modules-available/statistics_reporting/inc, branch masterWeb Interface zum Verwalten der Hochschul-/UniSpezifischen Einstellungen der Linux-Umgebunghttps://git.openslx.org/openslx-ng/slx-admin.git/atom/modules-available/statistics_reporting/inc?h=master2024-07-23T09:45:07+00:00[statistics_reporting] Fix undefined variable access2024-07-23T09:45:07+00:00Simon Rettberg2024-07-23T09:45:07+00:00urn:sha1:4f7dc7b5ee593a5fec3196f98505b6c62c0b45f6
This had no consequence as $start could only be
undefined if $bounds is false, in which case the variable $sh
was never read, but still, avoid the warning.
[statistics_reporting] Fix infinite loop2024-07-03T15:16:50+00:00Simon Rettberg2024-07-03T15:16:50+00:00urn:sha1:f736d67c0c1acae1b33190758e4160b898e8a6d4
If there are more than 1000 events with the same timestamp, we'd end up
in an infinite loop. Take care of this unusual case by increasing a
rowskip counter in this case.
Revert "[statistics_reporting] Consider all machines in DB"2024-02-07T14:04:52+00:00Simon Rettberg2024-02-07T14:04:52+00:00urn:sha1:9e20a3a775c4cb8100b345718af02a9e11109850
Revert these changes that would result in different results. We're still
not entirely clear how to handle the case of missing machines vs.
machines that just haven't been used for quite some time. So instead of
changing this now and possibly again in the near future, leave it as is
for now and then do something more clever in the near future.
This reverts commit 5dd6473d2f78d74c005ed20fb2a968f9bcae6ade.
[statistics_reporting] Consider all machines in DB2024-01-25T13:47:37+00:00Steffen Ritter2024-01-25T13:47:37+00:00urn:sha1:5dd6473d2f78d74c005ed20fb2a968f9bcae6ade
Don't limit on machines which booted at least once in the last 30 days.
Otherwise the number of machines in statistics_reporting doesn't match
the number of clients in rooms/locations or client-statistics which is
kinda irritating.
We still have the problem, that we don't know which clients still exist
in the real world. But that' another story.
Add function param/return types, fix a lot more phpstorm complaints2023-11-14T13:47:55+00:00Simon Rettberg2023-11-14T13:47:55+00:00urn:sha1:06bff0b9b84d47c43f9bc8aff06a29d85ebb7ed0Roundup of issues reported by PHPStorm2023-11-02T18:08:58+00:00Simon Rettberg2023-11-02T18:08:58+00:00urn:sha1:c2d95ffaeaa289752b4c7b6664b6ca112a02e350
Mostly redundant checks, logic errors, dead code, etc.
[statistics_reporting] Report legacy VMware CPUs2023-09-25T13:47:05+00:00Simon Rettberg2023-09-25T13:47:05+00:00urn:sha1:d98f3547e8d21b86ba25f3c4521cd3ec7777df46[statistics_reporting] Future-proof mem check :>2023-09-25T13:46:48+00:00Simon Rettberg2023-09-25T13:46:48+00:00urn:sha1:c2b5d25d4aa5cf98375559b322feeb7a33f45bea[statistics_reporting] Fix phpstorm complaints2023-06-20T12:24:13+00:00Simon Rettberg2023-06-20T12:24:13+00:00urn:sha1:7a535381a472e6013630396509c8ebba1aa39c45[statistics_reporting] Fallback for IP and hostname2022-08-22T12:55:33+00:00Steffen Ritter2022-08-22T12:55:33+00:00urn:sha1:674ef0cb8de1872c4e2bce7f9ec0d6ca9a9eb3f7
The php '$_SERVER' variables are not populated when executed by
a cron job. As fallback use the server adress from ipxe-module.