From 023db3416788f4ef23a0365db74878fde44970fe Mon Sep 17 00:00:00 2001 From: Simon Rettberg Date: Fri, 29 Jan 2021 14:29:41 +0100 Subject: [permissionmanager] Fix install always reporting UPDATE_DONE --- modules-available/permissionmanager/install.inc.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/modules-available/permissionmanager/install.inc.php b/modules-available/permissionmanager/install.inc.php index 9ff5a2d4..292a5f52 100644 --- a/modules-available/permissionmanager/install.inc.php +++ b/modules-available/permissionmanager/install.inc.php @@ -199,8 +199,10 @@ if (Database::exec("INSERT INTO `role` (roleid, rolename, builtin, roledescripti (2,'webinterface.*')"); Database::exec("OPTIMIZE TABLE role_x_permission"); // Assign the first user to the superadmin role (if one exists) - Database::exec("INSERT IGNORE INTO `role_x_user` VALUES (1,1)"); - $res[] = UPDATE_DONE; + $num = Database::exec("INSERT IGNORE INTO `role_x_user` VALUES (1,1)"); + if ($num > 0) { + $res[] = UPDATE_DONE; + } } // -- cgit v1.2.3-55-g7522