From b9f2db0d1cabe2b7180e230d3a19d64af5816e5b Mon Sep 17 00:00:00 2001 From: Simon Rettberg Date: Thu, 27 Feb 2020 16:53:14 +0100 Subject: [runmode] Fix undefined variable access --- modules-available/runmode/page.inc.php | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/modules-available/runmode/page.inc.php b/modules-available/runmode/page.inc.php index f8b48152..0b6dfa02 100644 --- a/modules-available/runmode/page.inc.php +++ b/modules-available/runmode/page.inc.php @@ -221,14 +221,13 @@ class Page_RunMode extends Page $modules[$row['module']]['list'][] = $row; } foreach ($modules as $moduleId => $rows) { + $disabled = ''; if ($onlyModule === false) { // Permissions - not required if rendering specific module, since it's been already done - if ($rows['config']->userHasPermission(null)) { - $disabled = ''; - } elseif (User::hasPermission('list-all')) { + if (!$rows['config']->userHasPermission(null)) { + if (!User::hasPermission('list-all')) + continue; $disabled = 'disabled'; - } else { - continue; } // } $module = Module::get($moduleId); -- cgit v1.2.3-55-g7522