From c2d95ffaeaa289752b4c7b6664b6ca112a02e350 Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Thu, 2 Nov 2023 19:08:58 +0100
Subject: Roundup of issues reported by PHPStorm

Mostly redundant checks, logic errors, dead code, etc.
---
 modules-available/adduser/page.inc.php | 3 ---
 1 file changed, 3 deletions(-)

(limited to 'modules-available/adduser/page.inc.php')

diff --git a/modules-available/adduser/page.inc.php b/modules-available/adduser/page.inc.php
index e81e9fb2..499436ff 100644
--- a/modules-available/adduser/page.inc.php
+++ b/modules-available/adduser/page.inc.php
@@ -32,10 +32,8 @@ class Page_AddUser extends Page
 		$email = Request::post('email', '', 'string');
 		if (empty($login) || empty($pass1) || empty($pass2) || empty($fullname)) {
 			Message::addError('main.empty-field');
-			return;
 		} elseif ($pass1 !== $pass2) {
 			Message::addError('password-mismatch');
-			return;
 		} else {
 			if (Database::queryFirst('SELECT userid FROM user LIMIT 1') !== false) {
 				User::assertPermission('user.add');
@@ -69,7 +67,6 @@ class Page_AddUser extends Page
 			}
 			Message::addInfo('adduser-success');
 			$this->saveRoles($id);
-			return;
 		}
 	}
 
-- 
cgit v1.2.3-55-g7522