From 8dc2b92d667f1401ab9f1315a36add61658f899c Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Thu, 6 May 2021 10:26:09 +0200
Subject: Moderize Database handling

* Auto-convert to utf8mb4_unicode_520_ci
* Use foreach instead of while to loop over results
* Drop useless statement caching
* Keep emulated prepares, as we sometimes loop over nested queries
---
 modules-available/dnbd3/page.inc.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'modules-available/dnbd3/page.inc.php')

diff --git a/modules-available/dnbd3/page.inc.php b/modules-available/dnbd3/page.inc.php
index d0842c23..a58f6fcc 100644
--- a/modules-available/dnbd3/page.inc.php
+++ b/modules-available/dnbd3/page.inc.php
@@ -174,7 +174,7 @@ class Page_Dnbd3 extends Page
 		$NOW = time();
 		$externalAllowed = User::hasPermission('configure.external');
 		$locsRunmode = User::getAllowedLocations('configure.proxy');
-		while ($server = $res->fetch(PDO::FETCH_ASSOC)) {
+		foreach ($res as $server) {
 			if (!is_null($server['machineuuid'])) {
 				// Auto proxy
 				if (!isset($dynClients[$server['machineuuid']])) {
@@ -355,7 +355,7 @@ class Page_Dnbd3 extends Page
 			$loc['recCount'] = 0;
 		}
 		$showLocs = false;
-		while ($row = $res->fetch(PDO::FETCH_ASSOC)) {
+		foreach ($res as $row) {
 			settype($row['locationid'], 'int');
 			$loc =& $locCount[$row['locationid']];
 			$loc['clientCount'] = $row['cnt'];
-- 
cgit v1.2.3-55-g7522