From 0ee956702fc9afcb75fce96807d2034854cdf16d Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Mon, 12 Feb 2018 18:46:17 +0100
Subject: [eventlog] Simplify permission check

---
 modules-available/eventlog/page.inc.php | 51 ++++++++++++++-------------------
 1 file changed, 21 insertions(+), 30 deletions(-)

(limited to 'modules-available/eventlog/page.inc.php')

diff --git a/modules-available/eventlog/page.inc.php b/modules-available/eventlog/page.inc.php
index 320c3b07..c482eb93 100644
--- a/modules-available/eventlog/page.inc.php
+++ b/modules-available/eventlog/page.inc.php
@@ -6,43 +6,34 @@ class Page_EventLog extends Page
 	protected function doPreprocess()
 	{
 		User::load();
-		if (!User::isLoggedIn()) {
-			Message::addError('main.no-permission');
-			Util::redirect('?do=Main');
-		}
-		if (User::hasPermission("view")) {
-			User::setLastSeenEvent(Property::getLastWarningId());
-		}
+		User::assertPermission('view');
+		User::setLastSeenEvent(Property::getLastWarningId());
 	}
 
 	protected function doRender()
 	{
 		Render::addTemplate("heading");
-		if (User::hasPermission("view")) {
-			$today = date('d.m.Y');
-			$yesterday = date('d.m.Y', time() - 86400);
-			$lines = array();
-			$paginate = new Paginate("SELECT logid, dateline, logtypeid, description, extra FROM eventlog ORDER BY logid DESC", 50);
-			$res = $paginate->exec();
-			while ($row = $res->fetch(PDO::FETCH_ASSOC)) {
-				$day = date('d.m.Y', $row['dateline']);
-				if ($day === $today) {
-					$day = Dictionary::translate('lang_today');
-				} elseif ($day === $yesterday) {
-					$day = Dictionary::translate('lang_yesterday');
-				}
-				$row['date'] = $day . date(' H:i', $row['dateline']);
-				$row['icon'] = $this->typeToIcon($row['logtypeid']);
-				$row['color'] = $this->typeToColor($row['logtypeid']);
-				$lines[] = $row;
+		$today = date('d.m.Y');
+		$yesterday = date('d.m.Y', time() - 86400);
+		$lines = array();
+		$paginate = new Paginate("SELECT logid, dateline, logtypeid, description, extra FROM eventlog ORDER BY logid DESC", 50);
+		$res = $paginate->exec();
+		while ($row = $res->fetch(PDO::FETCH_ASSOC)) {
+			$day = date('d.m.Y', $row['dateline']);
+			if ($day === $today) {
+				$day = Dictionary::translate('lang_today');
+			} elseif ($day === $yesterday) {
+				$day = Dictionary::translate('lang_yesterday');
 			}
-
-			$paginate->render('_page', array(
-				'list' => $lines
-			));
-		} else {
-			Message::addError('main.no-permission');
+			$row['date'] = $day . date(' H:i', $row['dateline']);
+			$row['icon'] = $this->typeToIcon($row['logtypeid']);
+			$row['color'] = $this->typeToColor($row['logtypeid']);
+			$lines[] = $row;
 		}
+
+		$paginate->render('_page', array(
+			'list' => $lines
+		));
 	}
 
 	private function typeToIcon($type)
-- 
cgit v1.2.3-55-g7522


From 556e7ee54269bd94bfb166bae59ef51ad93df8aa Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Mon, 12 Feb 2018 18:49:36 +0100
Subject: [eventlog] Use Util::prettyTime for timestamp formatting

---
 modules-available/eventlog/page.inc.php | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

(limited to 'modules-available/eventlog/page.inc.php')

diff --git a/modules-available/eventlog/page.inc.php b/modules-available/eventlog/page.inc.php
index c482eb93..1c81983c 100644
--- a/modules-available/eventlog/page.inc.php
+++ b/modules-available/eventlog/page.inc.php
@@ -13,19 +13,11 @@ class Page_EventLog extends Page
 	protected function doRender()
 	{
 		Render::addTemplate("heading");
-		$today = date('d.m.Y');
-		$yesterday = date('d.m.Y', time() - 86400);
 		$lines = array();
 		$paginate = new Paginate("SELECT logid, dateline, logtypeid, description, extra FROM eventlog ORDER BY logid DESC", 50);
 		$res = $paginate->exec();
 		while ($row = $res->fetch(PDO::FETCH_ASSOC)) {
-			$day = date('d.m.Y', $row['dateline']);
-			if ($day === $today) {
-				$day = Dictionary::translate('lang_today');
-			} elseif ($day === $yesterday) {
-				$day = Dictionary::translate('lang_yesterday');
-			}
-			$row['date'] = $day . date(' H:i', $row['dateline']);
+			$row['date'] = Util::prettyTime($row['dateline']);
 			$row['icon'] = $this->typeToIcon($row['logtypeid']);
 			$row['color'] = $this->typeToColor($row['logtypeid']);
 			$lines[] = $row;
-- 
cgit v1.2.3-55-g7522