From 06bff0b9b84d47c43f9bc8aff06a29d85ebb7ed0 Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Tue, 14 Nov 2023 14:47:55 +0100
Subject: Add function param/return types, fix a lot more phpstorm complaints

---
 modules-available/eventlog/inc/filterruleprocessor.inc.php | 4 ++--
 modules-available/eventlog/pages/log.inc.php               | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

(limited to 'modules-available/eventlog')

diff --git a/modules-available/eventlog/inc/filterruleprocessor.inc.php b/modules-available/eventlog/inc/filterruleprocessor.inc.php
index 24b37444..dd0160d7 100644
--- a/modules-available/eventlog/inc/filterruleprocessor.inc.php
+++ b/modules-available/eventlog/inc/filterruleprocessor.inc.php
@@ -254,7 +254,7 @@ class FilterRuleProcessor
 	 * @param array $filter filter struct [op, arg, result]
 	 * @return ?array null if op doesn't match, processed result otherwise
 	 */
-	private static function matches(string $item, array $filter)
+	private static function matches(string $item, array $filter): ?array
 	{
 		$ok = false;
 		switch ($filter['op']) {
@@ -291,7 +291,7 @@ class FilterRuleProcessor
 		if ($filter['op'] !== 'regex') {
 			$out = [1 => $item];
 		}
-		return $out;
+		return $out ?? [];
 	}
 
 	private static function fillTemplate(string $template, array $values): string
diff --git a/modules-available/eventlog/pages/log.inc.php b/modules-available/eventlog/pages/log.inc.php
index bfb16d11..66826b08 100644
--- a/modules-available/eventlog/pages/log.inc.php
+++ b/modules-available/eventlog/pages/log.inc.php
@@ -26,7 +26,7 @@ class SubPage
 		));
 	}
 
-	private static function typeToIcon($type)
+	private static function typeToIcon(string $type): string
 	{
 		switch ($type) {
 		case 'info':
@@ -40,7 +40,7 @@ class SubPage
 		}
 	}
 
-	private static function typeToColor($type)
+	private static function typeToColor(string $type): string
 	{
 		switch ($type) {
 		case 'warning':
-- 
cgit v1.2.3-55-g7522