From dfca01bd4444478a9fa5a4f9778ee56b932f0e5c Mon Sep 17 00:00:00 2001
From: Christian Hofmaier
Date: Tue, 21 Nov 2017 17:28:34 +0100
Subject: [internetaccess] reworked permission system from "click and you get
 error" to "button is disabled due to lack of permission"

---
 modules-available/internetaccess/page.inc.php      | 42 +++++++++++-----------
 .../internetaccess/templates/_page.html            |  2 +-
 2 files changed, 21 insertions(+), 23 deletions(-)

(limited to 'modules-available/internetaccess')

diff --git a/modules-available/internetaccess/page.inc.php b/modules-available/internetaccess/page.inc.php
index b1dff722..89897fa4 100644
--- a/modules-available/internetaccess/page.inc.php
+++ b/modules-available/internetaccess/page.inc.php
@@ -15,29 +15,24 @@ class Page_InternetAccess extends Page
 		$action = Request::any('action', 'show');
 
 		if ($action == 'save') {
-			if (User::hasPermission("configuration.save")) {
-				if (isset($_POST['PROXY_CONF'])) {
-					$data = array();
-					foreach (array('PROXY_CONF', 'PROXY_ADDR', 'PROXY_PORT', 'PROXY_USERNAME', 'PROXY_PASSWORD') as $key) {
-						$data[$key] = Request::post($key, '');
-					}
-					if (!FileUtil::arrayToFile(CONFIG_PROXY_CONF, $data)) {
-						Message::addError('main.error-write', CONFIG_PROXY_CONF);
-						Util::redirect();
-					} else {
-						Message::addSuccess('settings-updated');
-						Taskmanager::release(Taskmanager::submit('ReloadProxy'));
-						$taskids = array();
-						Trigger::stopDaemons(NULL, $taskids);
-						$taskids = array();
-						Trigger::startDaemons(NULL, $taskids);
-						Session::set('ia-restart', $taskids);
-						Util::redirect('?do=InternetAccess&show=update');
-					}
+			if (isset($_POST['PROXY_CONF'])) {
+				$data = array();
+				foreach (array('PROXY_CONF', 'PROXY_ADDR', 'PROXY_PORT', 'PROXY_USERNAME', 'PROXY_PASSWORD') as $key) {
+					$data[$key] = Request::post($key, '');
+				}
+				if (!FileUtil::arrayToFile(CONFIG_PROXY_CONF, $data)) {
+					Message::addError('main.error-write', CONFIG_PROXY_CONF);
+					Util::redirect();
+				} else {
+					Message::addSuccess('settings-updated');
+					Taskmanager::release(Taskmanager::submit('ReloadProxy'));
+					$taskids = array();
+					Trigger::stopDaemons(NULL, $taskids);
+					$taskids = array();
+					Trigger::startDaemons(NULL, $taskids);
+					Session::set('ia-restart', $taskids);
+					Util::redirect('?do=InternetAccess&show=update');
 				}
-			} else {
-				Message::addError('main.no-permission');
-				Util::redirect('?do=internetaccess');
 			}
 		}
 	}
@@ -56,6 +51,9 @@ class Page_InternetAccess extends Page
 		if (!isset($data['PROXY_CONF']))
 			$data['PROXY_CONF'] = 'AUTO';
 		$data['selected_' . $data['PROXY_CONF']] = 'selected';
+
+		$data['allowedSave'] = User::hasPermission("configuration.safe");
+
 		Render::addTemplate('_page', $data);
 	}
 
diff --git a/modules-available/internetaccess/templates/_page.html b/modules-available/internetaccess/templates/_page.html
index d363561e..1413e280 100644
--- a/modules-available/internetaccess/templates/_page.html
+++ b/modules-available/internetaccess/templates/_page.html
@@ -33,6 +33,6 @@
 	</div>
 	<br/>
 	<div class="text-right">
-		<button class="btn btn-primary" type="submit"><span class="glyphicon glyphicon-floppy-disk"></span> {{lang_save}}</button>
+		<button {{^allowedSave}}disabled{{/allowedSave}} class="btn btn-primary" type="submit"><span class="glyphicon glyphicon-floppy-disk"></span> {{lang_save}}</button>
 	</div>
 </form>
-- 
cgit v1.2.3-55-g7522