From 8dc2b92d667f1401ab9f1315a36add61658f899c Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Thu, 6 May 2021 10:26:09 +0200
Subject: Moderize Database handling

* Auto-convert to utf8mb4_unicode_520_ci
* Use foreach instead of while to loop over results
* Drop useless statement caching
* Keep emulated prepares, as we sometimes loop over nested queries
---
 modules-available/locations/pages/details.inc.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'modules-available/locations/pages/details.inc.php')

diff --git a/modules-available/locations/pages/details.inc.php b/modules-available/locations/pages/details.inc.php
index 356620d3..86bfebd6 100644
--- a/modules-available/locations/pages/details.inc.php
+++ b/modules-available/locations/pages/details.inc.php
@@ -322,7 +322,7 @@ class SubPage
 		$res = Database::simpleQuery("SELECT subnetid, startaddr, endaddr FROM subnet WHERE locationid = :lid",
 			array('lid' => $locationId));
 		$rows = array();
-		while ($row = $res->fetch(PDO::FETCH_ASSOC)) {
+		foreach ($res as $row) {
 			$row['startaddr'] = long2ip($row['startaddr']);
 			$row['endaddr'] = long2ip($row['endaddr']);
 			$rows[] = $row;
@@ -360,7 +360,7 @@ class SubPage
 		if (Module::get('statistics') !== false) {
 			$mres = Database::simpleQuery("SELECT state FROM machine"
 				. " WHERE machine.locationid = :lid", array('lid' => $locationId));
-			while ($row = $mres->fetch(PDO::FETCH_ASSOC)) {
+			foreach ($mres as $row) {
 				$count++;
 				if ($row['state'] === 'IDLE') {
 					$online++;
-- 
cgit v1.2.3-55-g7522