From c2d95ffaeaa289752b4c7b6664b6ca112a02e350 Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Thu, 2 Nov 2023 19:08:58 +0100
Subject: Roundup of issues reported by PHPStorm

Mostly redundant checks, logic errors, dead code, etc.
---
 .../permissionmanager/inc/permissionutil.inc.php           | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

(limited to 'modules-available/permissionmanager/inc/permissionutil.inc.php')

diff --git a/modules-available/permissionmanager/inc/permissionutil.inc.php b/modules-available/permissionmanager/inc/permissionutil.inc.php
index 20023281..d3f20b4f 100644
--- a/modules-available/permissionmanager/inc/permissionutil.inc.php
+++ b/modules-available/permissionmanager/inc/permissionutil.inc.php
@@ -132,15 +132,13 @@ class PermissionUtil
 					if (!$cacheAll)
 						break;
 				}
-				if ($cacheAll) {
-					$cache[$key][(int)$row['locationid']] = true;
-					$list = ($row['locationid'] === null) ? array_keys($allLocs) : $allLocs[(int)$row['locationid']]['children'];
-					foreach ($list as $lid) {
-						$cache[$key][$lid] = true;
-					}
-					if ($row['locationid'] === null)
-						break;
+				$cache[$key][(int)$row['locationid']] = true;
+				$list = ($row['locationid'] === null) ? array_keys($allLocs) : $allLocs[(int)$row['locationid']]['children'];
+				foreach ($list as $lid) {
+					$cache[$key][$lid] = true;
 				}
+				if ($row['locationid'] === null)
+					break;
 			}
 		}
 		if ($locationid === null) {
-- 
cgit v1.2.3-55-g7522