From d033483d3ed9e05f1109a3713ec6a3df883a1dae Mon Sep 17 00:00:00 2001 From: Udo Walter Date: Fri, 7 Apr 2017 15:49:54 +0200 Subject: [permission-manager] renamed some files, moved html generation to templates, using bind variables in mysql code, changed order of modules in role editor --- modules-available/permissionmanager/page.inc.php | 67 ++++++++++-------------- 1 file changed, 27 insertions(+), 40 deletions(-) (limited to 'modules-available/permissionmanager/page.inc.php') diff --git a/modules-available/permissionmanager/page.inc.php b/modules-available/permissionmanager/page.inc.php index 15d2fb73..3c72cfe4 100644 --- a/modules-available/permissionmanager/page.inc.php +++ b/modules-available/permissionmanager/page.inc.php @@ -19,20 +19,20 @@ class Page_PermissionManager extends Page if ($action === 'addRoleToUser') { $users = Request::post('users', ''); $roles = Request::post('roles', ''); - DbUpdate::addRoleToUser($users, $roles); + PermissionDbUpdate::addRoleToUser($users, $roles); } elseif ($action === 'removeRoleFromUser') { $users = Request::post('users', ''); $roles = Request::post('roles', ''); - DbUpdate::removeRoleFromUser($users, $roles); + PermissionDbUpdate::removeRoleFromUser($users, $roles); } elseif ($action === 'deleteRole') { $id = Request::post('deleteId', false, 'string'); - DbUpdate::deleteRole($id); + PermissionDbUpdate::deleteRole($id); } elseif ($action === 'saveRole') { $roleID = Request::post("roleid", false); $roleName = Request::post("roleName"); $locations = Request::post("allLocations", "off") == "on" ? array(0) : Request::post("locations"); $permissions = Request::post("allPermissions", "off") == "on" ? array("*") : Request::post("permissions");; - DbUpdate::saveRole($roleName, $locations, $permissions, $roleID); + PermissionDbUpdate::saveRole($roleName, $locations, $permissions, $roleID); } } @@ -55,14 +55,14 @@ class Page_PermissionManager extends Page Render::closeTag('div'); if ($show === "roles") { - $data = array("roles" => GetData::getRoles()); - Render::addTemplate('rolesTable', $data); + $data = array("roles" => GetPermissionData::getRoles()); + Render::addTemplate('rolestable', $data); } elseif ($show === "users") { - $data = array("user" => GetData::getUserData(), "roles" => GetData::getRoles()); - Render::addTemplate('usersTable', $data); + $data = array("user" => GetPermissionData::getUserData(), "roles" => GetPermissionData::getRoles()); + Render::addTemplate('userstable', $data); } elseif ($show === "locations") { - $data = array("location" => GetData::getLocationData()); - Render::addTemplate('locationsTable', $data); + $data = array("location" => GetPermissionData::getLocationData()); + Render::addTemplate('locationstable', $data); } } elseif ($show === "roleEditor") { $data = array(); @@ -70,7 +70,7 @@ class Page_PermissionManager extends Page $roleID = Request::get("roleid", false); $selectedLocations = array(); if ($roleID) { - $roleData = GetData::getRoleData($roleID); + $roleData = GetPermissionData::getRoleData($roleID); $data["roleid"] = $roleID; $data["roleName"] = $roleData["name"]; if (count($roleData["locations"]) == 1 && $roleData["locations"][0] == 0) { @@ -94,7 +94,7 @@ class Page_PermissionManager extends Page $permissions = PermissionUtil::getPermissions(); $permissionHTML = ""; foreach ($permissions as $k => $v) { - $name = Dictionary::translateFileModule($k, "module", "module_name"); + $name = Module::get($k)->getDisplayName(); $permissionHTML .= "
- "; - $permissionHTML .= self::generateSubPermissionHTML($v, $k); + "; + $permissionHTML .= self::generatePermissionHTML($v, $k); $permissionHTML .= "
"; } - $data["locations"] = GetData::getLocations($selectedLocations); + $data["locations"] = GetPermissionData::getLocations($selectedLocations); $data["moduleNames"] = array(); foreach (array_keys($permissions) as $moduleid) { - $data["moduleNames"][] = array("id" => $moduleid, - "name" => Dictionary::translateFileModule($moduleid, "module", "module_name")); + $data["moduleNames"][] = array("id" => $moduleid, "name" => Module::get($moduleid)->getDisplayName()); } $data["permissionHTML"] = $permissionHTML; - Render::addTemplate('roleEditor', $data); + Render::addTemplate('roleeditor', $data); + } } @@ -143,31 +143,18 @@ class Page_PermissionManager extends Page return $buttonColors; } - private static function generateSubPermissionHTML($subPermissions, $permissionString) + private static function generatePermissionHTML($subPermissions, $permString) { - $html = ""; - return $html; + return $res; } } -- cgit v1.2.3-55-g7522