From 06bff0b9b84d47c43f9bc8aff06a29d85ebb7ed0 Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Tue, 14 Nov 2023 14:47:55 +0100
Subject: Add function param/return types, fix a lot more phpstorm complaints

---
 modules-available/runmode/page.inc.php | 28 ++++++++++++----------------
 1 file changed, 12 insertions(+), 16 deletions(-)

(limited to 'modules-available/runmode/page.inc.php')

diff --git a/modules-available/runmode/page.inc.php b/modules-available/runmode/page.inc.php
index cceefae8..5654456a 100644
--- a/modules-available/runmode/page.inc.php
+++ b/modules-available/runmode/page.inc.php
@@ -30,7 +30,7 @@ class Page_RunMode extends Page
 		$module = Request::post('module', false, 'string');
 		$modeId = Request::post('modeid', false, 'string');
 		$modConfig = RunMode::getModuleConfig($module);
-		if ($modConfig === false) {
+		if ($modConfig === null) {
 			Message::addError('runmode.module-hasnt-runmode', $module);
 			return;
 		}
@@ -70,7 +70,7 @@ class Page_RunMode extends Page
 				if ($oldMachineMode !== false) {
 					$machineLocation = $oldMachineMode['locationid'];
 					$oldModule = RunMode::getModuleConfig($oldMachineMode['module']);
-					if ($oldModule !== false) {
+					if ($oldModule !== null) {
 						if ($oldMachineMode['module'] !== $module || $oldMachineMode['modeid'] !== $modeId) {
 							if (!$oldModule->allowGenericEditor || $oldModule->deleteUrlSnippet !== false) {
 								Message::addError('runmode.machine-still-assigned', $machine, $oldMachineMode['module']);
@@ -87,7 +87,7 @@ class Page_RunMode extends Page
 				} else {
 					// Not existing, no old mode - query machine to get location, so we can do a perm-check for new loc
 					$m = Statistics::getMachine($machine, Machine::NO_DATA);
-					if ($m !== false) {
+					if ($m !== null) {
 						$machineLocation = $m->locationid;
 					}
 				}
@@ -134,7 +134,7 @@ class Page_RunMode extends Page
 			return;
 		}
 		$modConfig = RunMode::getModuleConfig($mode['module']);
-		if ($modConfig === false) {
+		if ($modConfig === null) {
 			Message::addError('module-hasnt-runmode', $mode['moduleName']);
 			return;
 		}
@@ -172,7 +172,7 @@ class Page_RunMode extends Page
 		}
 		$module->activate(1, false);
 		$config = RunMode::getModuleConfig($moduleId);
-		if ($config === false) {
+		if ($config === null) {
 			Message::addError('module-hasnt-runmode', $moduleId);
 			Util::redirect('?do=runmode');
 		}
@@ -187,7 +187,6 @@ class Page_RunMode extends Page
 		if (!$config->userHasPermission(null) && !User::hasPermission('list-all')) {
 			Message::addError('main.no-permission');
 			Util::redirect('?do=runmode');
-			return;
 		}
 		// Show list of machines with assigned mode for this module
 		$this->renderClientList($moduleId);
@@ -212,7 +211,10 @@ class Page_RunMode extends Page
 			if (!isset($modules[$row['module']])) {
 				if (!Module::isAvailable($row['module']))
 					continue;
-				$modules[$row['module']] = array('config' => RunMode::getModuleConfig($row['module']), 'list' => array());
+				$config = RunMode::getModuleConfig($row['module']);
+				if ($config === null)
+					continue;
+				$modules[$row['module']] = array('config' => $config, 'list' => array());
 			}
 			if (empty($row['hostname'])) {
 				$row['hostname'] = $row['clientip'];
@@ -244,7 +246,7 @@ class Page_RunMode extends Page
 				'list' => $rows['list'],
 				'modulename' => $module->getDisplayName(),
 				'module' => $moduleId,
-				'canedit' => $config !== false && $config->allowGenericEditor && $config->deleteUrlSnippet === false,
+				'canedit' => $config !== null && $config->allowGenericEditor && $config->deleteUrlSnippet === false,
 				'deleteUrl' => $config->deleteUrlSnippet,
 				'disabled' => $disabled,
 			));
@@ -254,12 +256,7 @@ class Page_RunMode extends Page
 		}
 	}
 
-	/**
-	 * @param \Module $module
-	 * @param string $modeId
-	 * @param \RunModeModuleConfig $config
-	 */
-	private function renderModuleMode($module, $modeId, $config)
+	private function renderModuleMode(Module $module, string $modeId, RunModeModuleConfig $config)
 	{
 		$moduleId = $module->getIdentifier();
 		$modeName = RunMode::getModeName($moduleId, $modeId);
@@ -283,7 +280,6 @@ class Page_RunMode extends Page
 		} else {
 			Message::addError('main.no-permission');
 			Util::redirect('?do=runmode');
-			return;
 		}
 		$machines = RunMode::getForMode($module, $modeId, true);
 		if ($config->permission !== false) {
@@ -317,7 +313,7 @@ class Page_RunMode extends Page
 		$config = RunMode::getModuleConfig(Request::any('module', '', 'string'));
 		$returnObject = ['machines' => []];
 
-		if ($config !== false) {
+		if ($config !== null) {
 			$params = ['query' => "%$query%"];
 			if ($config->permission === false) {
 				// Global
-- 
cgit v1.2.3-55-g7522