From c2d95ffaeaa289752b4c7b6664b6ca112a02e350 Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Thu, 2 Nov 2023 19:08:58 +0100
Subject: Roundup of issues reported by PHPStorm

Mostly redundant checks, logic errors, dead code, etc.
---
 modules-available/serversetup-bwlp-ipxe/inc/bootentryhook.inc.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'modules-available/serversetup-bwlp-ipxe/inc/bootentryhook.inc.php')

diff --git a/modules-available/serversetup-bwlp-ipxe/inc/bootentryhook.inc.php b/modules-available/serversetup-bwlp-ipxe/inc/bootentryhook.inc.php
index 73611b0a..060b3903 100644
--- a/modules-available/serversetup-bwlp-ipxe/inc/bootentryhook.inc.php
+++ b/modules-available/serversetup-bwlp-ipxe/inc/bootentryhook.inc.php
@@ -94,8 +94,8 @@ abstract class BootEntryHook
 	public function renderExtraFields()
 	{
 		$list = $this->extraFields();
-		foreach ($list as &$entry) {
-			$entry->currentValue = isset($this->data[$entry->name]) ? $this->data[$entry->name] : $entry->default;
+		foreach ($list as $entry) {
+			$entry->currentValue = $this->data[$entry->name] ?? $entry->default;
 			$entry->hook = $this;
 		}
 		return $list;
-- 
cgit v1.2.3-55-g7522