From aa49154e5a9ee135c3f0286ddda8a01a5290b1ed Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Wed, 15 Nov 2023 17:53:47 +0100
Subject: Fix more type errors, stricter typing

---
 modules-available/sysconfig/addmodule_adauth.inc.php | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

(limited to 'modules-available/sysconfig/addmodule_adauth.inc.php')

diff --git a/modules-available/sysconfig/addmodule_adauth.inc.php b/modules-available/sysconfig/addmodule_adauth.inc.php
index 2a695ab0..42187171 100644
--- a/modules-available/sysconfig/addmodule_adauth.inc.php
+++ b/modules-available/sysconfig/addmodule_adauth.inc.php
@@ -130,7 +130,7 @@ class AdAuth_SelfSearch extends AddModule_Base
 
 	protected function preprocessInternal()
 	{
-		$server = $binddn = $port = null;
+		$server = $binddn = null;
 		$searchbase = Request::post('searchbase', '');
 		$bindpw = Request::post('bindpw');
 		$ssl = Request::post('ssl', 'off') === 'on';
@@ -139,14 +139,8 @@ class AdAuth_SelfSearch extends AddModule_Base
 			AddModule_Base::setStep('AdAuth_Start'); // Continues with AdAuth_Start for render()
 			return;
 		}
-		foreach (['server', 'binddn', 'port'] as $var) {
-			$$var = Request::post($var, null);
-			if (empty($$var)) {
-				Message::addError('main.parameter-empty', $var);
-				AddModule_Base::setStep('AdAuth_Start'); // Continues with AdAuth_Start for render()
-				return;
-			}
-		}
+		$server = Request::post('server', Request::REQUIRED, 'string');
+		$binddn = Request::post('binddn', Request::REQUIRED, 'string');
 		$this->originalBindDn = '';
 		// Fix bindDN if short name given
 		//
-- 
cgit v1.2.3-55-g7522