From 06bff0b9b84d47c43f9bc8aff06a29d85ebb7ed0 Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Tue, 14 Nov 2023 14:47:55 +0100
Subject: Add function param/return types, fix a lot more phpstorm complaints

---
 .../sysconfig/addmodule_custommodule.inc.php       | 26 ++++++++++------------
 1 file changed, 12 insertions(+), 14 deletions(-)

(limited to 'modules-available/sysconfig/addmodule_custommodule.inc.php')

diff --git a/modules-available/sysconfig/addmodule_custommodule.inc.php b/modules-available/sysconfig/addmodule_custommodule.inc.php
index 234aed0d..3afdad0a 100644
--- a/modules-available/sysconfig/addmodule_custommodule.inc.php
+++ b/modules-available/sysconfig/addmodule_custommodule.inc.php
@@ -14,7 +14,7 @@ class CustomModule_Start extends AddModule_Base
 		Session::set('mod_temp', false);
 		Render::addDialog(Dictionary::translateFile('config-module', 'custom_title'), false, 'custom-upload', array(
 			'step' => 'CustomModule_ProcessUpload',
-			'edit' => $this->edit ? $this->edit->id() : false
+			'edit' => $this->edit === null ? null : $this->edit->id(),
 			));
 	}
 
@@ -69,17 +69,17 @@ class CustomModule_ProcessUpload extends AddModule_Base
 		}
 		$list = SysConfig::archiveContentsFromTask($status, $userGroupWarn);
 
-		if ($this->edit !== false) {
+		if ($this->edit !== null) {
 			$title = $this->edit->title();
 		} else if (isset($_FILES['modulefile']['name'])) {
 			$title = basename($_FILES['modulefile']['name']);
 		} else {
 			$title = '';
 		}
-		Render::addDialog(Dictionary::translate('config-module', 'custom_title'), false, 'custom-fileselect', array(
+		Render::addDialog(Dictionary::translateFile('config-module', 'custom_title'), false, 'custom-fileselect', array(
 			'step' => 'CustomModule_CompressModule',
 			'files' => $list,
-			'edit' => $this->edit ? $this->edit->id() : false,
+			'edit' => $this->edit === null ? null : $this->edit->id(),
 			'title' => $title,
 			'userGroupWarn' => $userGroupWarn,
 		));
@@ -116,28 +116,26 @@ class CustomModule_CompressModule extends AddModule_Base
 			$this->taskError($status);
 		}
 		// Seems ok, create entry
-		if ($this->edit === false)
+		if ($this->edit === null) {
 			$module = ConfigModule::getInstance('CustomModule');
-		else
+		} else {
 			$module = $this->edit;
-		if ($module === false) {
-			Message::addError('main.error-read', 'custommodule.inc.php');
-			Util::redirect('?do=SysConfig&action=addmodule&step=CustomModule_Start');
 		}
 		$module->setData('tmpFile', $destFile);
-		if ($this->edit !== false)
+		if ($this->edit !== null) {
 			$ret = $module->update($title);
-		else
+		} else {
 			$ret = $module->insert($title);
+		}
 		if (!$ret)
 			Util::redirect('?do=SysConfig&action=addmodule&step=CustomModule_Start');
-		elseif (!$module->generate($this->edit === false, NULL, 200))
+		elseif (!$module->generate($this->edit === null, NULL, 200))
 			Util::redirect('?do=SysConfig&action=addmodule&step=CustomModule_Start');
 		Session::set('mod_temp', false);
 		// Yay
-		if ($this->edit !== false)
+		if ($this->edit !== null) {
 			Message::addSuccess('module-edited');
-		else {
+		} else {
 			Message::addSuccess('module-added');
 			AddModule_Base::setStep('AddModule_Assign', $module->id());
 			return;
-- 
cgit v1.2.3-55-g7522