From c2d95ffaeaa289752b4c7b6664b6ca112a02e350 Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Thu, 2 Nov 2023 19:08:58 +0100
Subject: Roundup of issues reported by PHPStorm

Mostly redundant checks, logic errors, dead code, etc.
---
 modules-available/sysconfig/inc/configmodule/branding.inc.php | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

(limited to 'modules-available/sysconfig/inc/configmodule/branding.inc.php')

diff --git a/modules-available/sysconfig/inc/configmodule/branding.inc.php b/modules-available/sysconfig/inc/configmodule/branding.inc.php
index 8990dbec..76968ff4 100644
--- a/modules-available/sysconfig/inc/configmodule/branding.inc.php
+++ b/modules-available/sysconfig/inc/configmodule/branding.inc.php
@@ -22,13 +22,12 @@ class ConfigModule_Branding extends ConfigModule
 		if (!$this->validateConfig()) {
 			return $this->archive() !== false && file_exists($this->archive()); // No new temp file given, old archive still exists, pretend it worked...
 		}
-		$task = Taskmanager::submit('MoveFile', array(
+		return Taskmanager::submit('MoveFile', array(
 			'source' => $this->tmpFile,
 			'destination' => $tgz,
 			'parentTask' => $parent,
 			'failOnParentFail' => false
 		));
-		return $task;
 	}
 
 	protected function moduleVersion()
-- 
cgit v1.2.3-55-g7522