From 8dc2b92d667f1401ab9f1315a36add61658f899c Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Thu, 6 May 2021 10:26:09 +0200
Subject: Moderize Database handling

* Auto-convert to utf8mb4_unicode_520_ci
* Use foreach instead of while to loop over results
* Drop useless statement caching
* Keep emulated prepares, as we sometimes loop over nested queries
---
 modules-available/sysconfig/install.inc.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'modules-available/sysconfig/install.inc.php')

diff --git a/modules-available/sysconfig/install.inc.php b/modules-available/sysconfig/install.inc.php
index e9eaaf50..6c9edba2 100644
--- a/modules-available/sysconfig/install.inc.php
+++ b/modules-available/sysconfig/install.inc.php
@@ -87,7 +87,7 @@ if (!tableHasColumn('configtgz_module', 'dateline')) {
 	$update[] = UPDATE_DONE;
 	// Infer from module's filemtime
 	$res = Database::simpleQuery('SELECT moduleid, filepath FROM configtgz_module');
-	while ($row = $res->fetch(PDO::FETCH_ASSOC)) {
+	foreach ($res as $row) {
 		Database::exec('UPDATE configtgz_module SET dateline = :mtime WHERE moduleid = :moduleid',
 			['moduleid' => $row['moduleid'], 'mtime' => filemtime($row['filepath'])]);
 	}
@@ -102,7 +102,7 @@ if (!tableHasColumn('configtgz', 'dateline')) {
 			INNER JOIN configtgz_x_module cxm USING (configid)
 			INNER JOIN configtgz_module m USING (moduleid)
 			GROUP BY configid');
-	while ($row = $res->fetch(PDO::FETCH_ASSOC)) {
+	foreach ($res as $row) {
 		Database::exec('UPDATE configtgz SET dateline = :mtime WHERE configid = :configid',
 			['configid' => $row['configid'], 'mtime' => $row['dateline']]);
 	}
-- 
cgit v1.2.3-55-g7522