From c2d95ffaeaa289752b4c7b6664b6ca112a02e350 Mon Sep 17 00:00:00 2001 From: Simon Rettberg Date: Thu, 2 Nov 2023 19:08:58 +0100 Subject: Roundup of issues reported by PHPStorm Mostly redundant checks, logic errors, dead code, etc. --- modules-available/sysconfig/install.inc.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'modules-available/sysconfig/install.inc.php') diff --git a/modules-available/sysconfig/install.inc.php b/modules-available/sysconfig/install.inc.php index 6c9edba2..9d32137c 100644 --- a/modules-available/sysconfig/install.inc.php +++ b/modules-available/sysconfig/install.inc.php @@ -132,7 +132,7 @@ if ($list === false) { if ($ad->moduleType() === 'SshConfig') { // 2020-11-12: Split SshConfig into SshConfig and SshKey $pubkey = $ad->getData('publicKey'); - if ($pubkey !== false && !empty($pubkey)) { + if (!empty($pubkey)) { error_log('Legacy module with pubkey ' . $ad->id()); $key = ConfigModule::getInstance('SshKey'); if ($key !== false) { -- cgit v1.2.3-55-g7522