From 8dc2b92d667f1401ab9f1315a36add61658f899c Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Thu, 6 May 2021 10:26:09 +0200
Subject: Moderize Database handling

* Auto-convert to utf8mb4_unicode_520_ci
* Use foreach instead of while to loop over results
* Drop useless statement caching
* Keep emulated prepares, as we sometimes loop over nested queries
---
 modules-available/sysconfig/page.inc.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'modules-available/sysconfig/page.inc.php')

diff --git a/modules-available/sysconfig/page.inc.php b/modules-available/sysconfig/page.inc.php
index ff3983c1..e868ec67 100644
--- a/modules-available/sysconfig/page.inc.php
+++ b/modules-available/sysconfig/page.inc.php
@@ -188,7 +188,7 @@ class Page_SysConfig extends Page
 			$locationName = false;
 		}
 		$hasDefault = false;
-		while ($row = $res->fetch(PDO::FETCH_ASSOC)) {
+		foreach ($res as $row) {
 			if (is_null($row['loclist'])) {
 				$locList = array();
 			} else {
@@ -291,7 +291,7 @@ class Page_SysConfig extends Page
 			. " ORDER BY module.title ASC", array('configid' => $configid));
 
 		$modules = array();
-		while ($row = $res->fetch(PDO::FETCH_ASSOC)) {
+		foreach ($res as $row) {
 			$modules[] = array(
 				'module' => $row['moduletitle'],
 				'moduleid' => $row['moduleid']
@@ -375,7 +375,7 @@ class Page_SysConfig extends Page
 			Message::addSuccess('module-deleted', $module['title']);
 		}
 		// Rebuild depending config.tgz
-		while ($crow = $existing->fetch(PDO::FETCH_ASSOC)) {
+		foreach ($existing as $crow) {
 			$config = ConfigTgz::get($crow['configid']);
 			if ($config !== false) {
 				$config->generate();
-- 
cgit v1.2.3-55-g7522