From aa49154e5a9ee135c3f0286ddda8a01a5290b1ed Mon Sep 17 00:00:00 2001 From: Simon Rettberg Date: Wed, 15 Nov 2023 17:53:47 +0100 Subject: Fix more type errors, stricter typing --- modules-available/translation/page.inc.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'modules-available/translation/page.inc.php') diff --git a/modules-available/translation/page.inc.php b/modules-available/translation/page.inc.php index 578e27dc..4563b8e5 100644 --- a/modules-available/translation/page.inc.php +++ b/modules-available/translation/page.inc.php @@ -429,7 +429,7 @@ class Page_Translation extends Page */ private function loadUsedTemplateTags(Module $module = null): array { - if ($module === false) { + if ($module === null) { $module = $this->module; } $tags = array(); @@ -459,7 +459,7 @@ class Page_Translation extends Page */ private function loadUsedMessageTags(Module $module = null): array { - if ($module === false) { + if ($module === null) { $module = $this->module; } $allFiles = $this->getAllFiles('modules', '.php'); @@ -491,7 +491,7 @@ class Page_Translation extends Page */ private function loadUsedModuleTags(Module $module = null): array { - if ($module === false) { + if ($module === null) { $module = $this->module; } $tags = $this->loadTagsFromPhp('/Dictionary\s*::\s*translate\s*\(\s*[\'"](?[^\'"\.]*)[\'"]\s*[\),]/i', @@ -519,7 +519,7 @@ class Page_Translation extends Page $want = array(); foreach (Module::getAll() as $module) { $cat = $module->getCategory(); - if (substr($cat, 0, $skip) === $match) { + if ($cat !== null && substr($cat, 0, $skip) === $match) { $want[substr($cat, $skip)] = true; } } @@ -585,7 +585,7 @@ class Page_Translation extends Page */ private function getModuleTranslationStatus(string $lang, string $file, bool $fallback, array $tags, Module $module = null): array { - if ($module === false) { + if ($module === null) { $module = $this->module; } if ($fallback) { -- cgit v1.2.3-55-g7522