From 75746e15880c72487864ed62b860052eedc224b6 Mon Sep 17 00:00:00 2001 From: Simon Rettberg Date: Mon, 4 Jul 2016 15:22:05 +0200 Subject: [translation] Improve module list; move baseconfig hook to baseconfig_bwlp --- modules-available/translation/page.inc.php | 16 +++++++++++----- modules-available/translation/templates/module-list.html | 7 ++++++- 2 files changed, 17 insertions(+), 6 deletions(-) (limited to 'modules-available/translation') diff --git a/modules-available/translation/page.inc.php b/modules-available/translation/page.inc.php index 74cf27a8..563ffae0 100644 --- a/modules-available/translation/page.inc.php +++ b/modules-available/translation/page.inc.php @@ -593,20 +593,26 @@ class Page_Translation extends Page private function checkModuleTranslation($module) { - $tags = $this->loadUsedTemplateTags($module); + $templateTags = $this->loadUsedTemplateTags($module); + $messageTags = $this->loadUsedMessageTags($module); + $moduleTags = $this->loadUsedModuleTags($module); $msgs = ''; foreach (Dictionary::getLanguages() as $lang) { - list($missing, $unused) = $this->getModuleTemplateStatus($lang, $tags, $module); + list($m1, $u1) = $this->getModuleTemplateStatus($lang, $templateTags, $module); + list($m2, $u2) = $this->getModuleTranslationStatus($lang, 'messages', true, $messageTags, $module); + list($m3, $u3) = $this->getModuleTranslationStatus($lang, 'module', true, $moduleTags, $module); + $missing = $m1 + $m2 + $m3; + $unused = $u1 + $u2 + $u3; $msg = ""; if ($missing > 0) { - $msg .= " [$missing JSON tag(s) are missing] "; + $msg .= " [$missing missing] "; } if ($unused > 0) { - $msg .= " [$unused JSON tag(s) are not being used] "; + $msg .= " [$unused not being used] "; } if(!empty($msg)) { - $msgs .= "
$lang
$msg
"; + $msgs .= '
' . Dictionary::getFlagHtml(false, $lang) . '
' . $msg . '
'; } } if(empty($msgs)) { diff --git a/modules-available/translation/templates/module-list.html b/modules-available/translation/templates/module-list.html index 81dc741c..026e17e9 100644 --- a/modules-available/translation/templates/module-list.html +++ b/modules-available/translation/templates/module-list.html @@ -11,7 +11,12 @@ {{#table}} - {{module}} + + {{#depfail}} +
+ {{/depfail}} + {{module}} + {{{status}}} {{/table}} -- cgit v1.2.3-55-g7522