From 36a47b406e20cb17213817df3e33d2693f854d69 Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Fri, 12 Mar 2021 14:20:41 +0100
Subject: [statistics] Remove logintime filter

Would only work when a user is currently logged in, which is confusing.
Remove.
References #3842
---
 modules-available/statistics/inc/statisticsfilter.inc.php | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

(limited to 'modules-available')

diff --git a/modules-available/statistics/inc/statisticsfilter.inc.php b/modules-available/statistics/inc/statisticsfilter.inc.php
index ecb1f6b4..ed433e7c 100644
--- a/modules-available/statistics/inc/statisticsfilter.inc.php
+++ b/modules-available/statistics/inc/statisticsfilter.inc.php
@@ -221,7 +221,6 @@ abstract class StatisticsFilter
 			'macaddr' => new SimpleStatisticsFilter('macaddr', self::OP_STRCMP, '11-22-33-44-55-66'),
 			'firstseen' => new DateStatisticsFilter('firstseen', '2020-10-15 14:00'),
 			'lastseen' => new DateStatisticsFilter('lastseen', '2020-10-15 14:00'),
-			'logintime' => new DateStatisticsFilter('logintime', '2020-10-15 14:00'),
 			'lastboot' => new DateStatisticsFilter('lastboot', '2020-10-15 14:00'),
 			'runtime' => new RuntimeStatisticsFilter(),
 			'realcores' => new SimpleStatisticsFilter('realcores', self::OP_ORDINAL, ''),
@@ -338,7 +337,6 @@ class DateStatisticsFilter extends StatisticsFilter
 	public function whereClause(string $operator, $argument, array &$args, array &$joins)
 	{
 		$key = self::getNewKey($this->column);
-		$addendum = '';
 
 		if (!preg_match('/^(?<date>\d{4}-\d{2}-\d{2})(\s+(?<h>\d{1,2})(:(?<m>\d{2})(:\d+)?)?)?$/', $argument, $out)) {
 			Message::addError('invalid-date-format', $argument);
@@ -364,7 +362,7 @@ class DateStatisticsFilter extends StatisticsFilter
 			$args[$key] = strtotime('+1 ' . $span . ' -1 second', $args[$key]);
 		}
 
-		return 'm.' . $this->column . ' ' . $operator . ' :' . $key . $addendum;
+		return 'm.' . $this->column . ' ' . $operator . ' :' . $key;
 	}
 
 }
-- 
cgit v1.2.3-55-g7522