From cd55ead3e2810e209b726faca12fa749f6875d0f Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Sat, 16 Dec 2017 18:33:16 +0100
Subject: Fix A LOT of type problems, logic flaws, uninitialized variables etc.

Most of them were found by phpstorm, so I put in some time and
went through the list, fixing quite a bunch of them.
---
 tools/convert-modules.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'tools')

diff --git a/tools/convert-modules.php b/tools/convert-modules.php
index 9b479886..f8c7a1a5 100644
--- a/tools/convert-modules.php
+++ b/tools/convert-modules.php
@@ -182,8 +182,8 @@ foreach ($messages as $id => $modules) {
 	asort($modules, SORT_NUMERIC);
 	$modules = array_reverse($modules, true);
 	reset($modules);
-	list($topModule, $topCount) = each($modules);
-	reset($modules);
+	$topModule = key($modules);
+	$topCount = $modules[$topModule];
 	$sum = 0;
 	foreach ($modules as $c) {
 		$sum += $c;
-- 
cgit v1.2.3-55-g7522