From 67a4f15659514288f287816b233ea92ae153c099 Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Mon, 19 Apr 2021 13:03:10 +0200
Subject: [daemon] Assign thread names, fine tune socket timeouts

---
 .../taskmanager/network/NetworkHandlerTcp.java     | 30 ++++++++++++++++------
 1 file changed, 22 insertions(+), 8 deletions(-)

(limited to 'daemon/src/main/java/org/openslx/taskmanager/network/NetworkHandlerTcp.java')

diff --git a/daemon/src/main/java/org/openslx/taskmanager/network/NetworkHandlerTcp.java b/daemon/src/main/java/org/openslx/taskmanager/network/NetworkHandlerTcp.java
index 540ff42..8b8b6d5 100644
--- a/daemon/src/main/java/org/openslx/taskmanager/network/NetworkHandlerTcp.java
+++ b/daemon/src/main/java/org/openslx/taskmanager/network/NetworkHandlerTcp.java
@@ -9,8 +9,10 @@ import java.net.Socket;
 import java.nio.charset.StandardCharsets;
 import java.util.concurrent.RejectedExecutionException;
 import java.util.concurrent.SynchronousQueue;
+import java.util.concurrent.ThreadFactory;
 import java.util.concurrent.ThreadPoolExecutor;
 import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicInteger;
 
 import org.apache.log4j.Logger;
 import org.openslx.taskmanager.Global;
@@ -29,7 +31,15 @@ public class NetworkHandlerTcp extends NetworkHandlerBase
 	 */
 	private final ServerSocket socket;
 
-	private final ThreadPoolExecutor threadPool = new ThreadPoolExecutor( 1, 8, 1, TimeUnit.MINUTES, new SynchronousQueue<Runnable>() );
+	private final ThreadPoolExecutor threadPool = new ThreadPoolExecutor( 0, 64, 1, TimeUnit.MINUTES, new SynchronousQueue<Runnable>(), new ThreadFactory() {
+		AtomicInteger id = new AtomicInteger();
+
+		@Override
+		public Thread newThread( Runnable r )
+		{
+			return new Thread( r, "TCP-" + id.incrementAndGet() );
+		}
+	} );
 
 	/**
 	 * Initialize the NetworkHandler by starting threads and opening the socket.
@@ -77,7 +87,7 @@ public class NetworkHandlerTcp extends NetworkHandlerBase
 		} finally {
 			Thread.currentThread().interrupt();
 			Global.doShutdown = true;
-			log.info( "UDP receiver finished." );
+			log.info( "TCP receiver finished." );
 		}
 	}
 
@@ -86,7 +96,7 @@ public class NetworkHandlerTcp extends NetworkHandlerBase
 		private final Socket socket;
 		private DataOutputStream writer = null;
 		private DataInputStream reader = null;
-			
+
 		public ClientTask( Socket client )
 		{
 			this.socket = client;
@@ -97,7 +107,6 @@ public class NetworkHandlerTcp extends NetworkHandlerBase
 		{
 			try {
 				try {
-					socket.setSoTimeout( (int)TimeUnit.MINUTES.toMillis( 15 ) );
 					reader = new DataInputStream( socket.getInputStream() );
 					writer = new DataOutputStream( socket.getOutputStream() );
 				} catch ( IOException e ) {
@@ -145,7 +154,7 @@ public class NetworkHandlerTcp extends NetworkHandlerBase
 				}
 			}
 		}
-		
+
 		private void sendMsg( String reply ) throws SendException
 		{
 			sendMsg( reply.getBytes( StandardCharsets.UTF_8 ) );
@@ -154,6 +163,7 @@ public class NetworkHandlerTcp extends NetworkHandlerBase
 		private void sendMsg( byte[] reply ) throws SendException
 		{
 			try {
+				socket.setSoTimeout( (int)TimeUnit.SECONDS.toMillis( 15 ) );
 				writer.writeInt( reply.length );
 				writer.write( reply );
 			} catch ( IOException e ) {
@@ -165,6 +175,7 @@ public class NetworkHandlerTcp extends NetworkHandlerBase
 		{
 			int bytes;
 			try {
+				socket.setSoTimeout( (int)TimeUnit.MINUTES.toMillis( 15 ) );
 				bytes = reader.readInt();
 			} catch ( IOException e ) {
 				// This should be fine... Client went away
@@ -178,16 +189,19 @@ public class NetworkHandlerTcp extends NetworkHandlerBase
 				return ""; // Nothing to read
 			byte[] buffer = new byte[ bytes ];
 			try {
+				socket.setSoTimeout( (int)TimeUnit.SECONDS.toMillis( 2 ) );
 				reader.readFully( buffer );
 			} catch ( IOException e ) {
 				log.warn( "Client went away when trying to read payload" );
 				return null;
 			}
 			return new String( buffer, StandardCharsets.UTF_8 );
-		} 
+		}
 
 	}
-	
-	private static class SendException extends Exception {}
+
+	private static class SendException extends Exception
+	{
+	}
 
 }
-- 
cgit v1.2.3-55-g7522