From 0c54b3b868e4434d69be41de73fd74fc4685a298 Mon Sep 17 00:00:00 2001 From: Simon Rettberg Date: Tue, 15 Oct 2019 14:34:25 +0200 Subject: [client] THINK before commiting Setting variable before checking its value is a bad idea. --- .../org/openslx/dozmod/gui/wizard/page/ImageUploadSummaryPage.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dozentenmodul/src/main/java/org/openslx/dozmod/gui/wizard/page/ImageUploadSummaryPage.java b/dozentenmodul/src/main/java/org/openslx/dozmod/gui/wizard/page/ImageUploadSummaryPage.java index 55615a00..9b564979 100644 --- a/dozentenmodul/src/main/java/org/openslx/dozmod/gui/wizard/page/ImageUploadSummaryPage.java +++ b/dozentenmodul/src/main/java/org/openslx/dozmod/gui/wizard/page/ImageUploadSummaryPage.java @@ -142,8 +142,10 @@ public class ImageUploadSummaryPage extends ImageUploadSummaryPageLayout { @Override protected void onPageLeave() { + if (!pageIsVisible) + return; pageIsVisible = false; - if (!pageIsVisible || state == null) + if (state == null) return; // optional lectureWizard -- cgit v1.2.3-55-g7522