From 5e143d493eb088e3f5dce86e8906483e7efc909d Mon Sep 17 00:00:00 2001 From: Simon Rettberg Date: Mon, 28 Sep 2020 12:02:54 +0200 Subject: [server] Abort orphan scan/delete if known image list is empty On the off-chance that something goes wron when querying, or the database got emptied, don't just blindly wipe the whole vmstore. It's probably smarter to restore a backup first, or if you really mean to start afresh, just empty the vmstore manually, or just upload one VM and then use this feature again. --- dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/web/WebRpc.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/web/WebRpc.java b/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/web/WebRpc.java index 2709e567..1d5b27e7 100644 --- a/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/web/WebRpc.java +++ b/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/web/WebRpc.java @@ -85,6 +85,9 @@ public class WebRpc { } catch (SQLException e1) { return WebServer.internalServerError("Cannot query list of known images from database"); } + if (known.isEmpty()) { + return WebServer.internalServerError("SAFTY CHECK: Known image list empty, aborting"); + } try { // Consider only regular files, call checkFile for each one Files.find(Configuration.getVmStoreProdPath().toPath(), 8, -- cgit v1.2.3-55-g7522