From 871fab1a8be393f64a7998e6f2e31e2caea05ae9 Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Wed, 24 Feb 2016 17:54:42 +0100
Subject: [server] Log if an upload is aborted due to lack of disk space

---
 .../java/org/openslx/bwlp/sat/fileserv/IncomingDataTransfer.java    | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

(limited to 'dozentenmodulserver/src/main/java')

diff --git a/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/fileserv/IncomingDataTransfer.java b/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/fileserv/IncomingDataTransfer.java
index 7bad59a3..92f533e8 100644
--- a/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/fileserv/IncomingDataTransfer.java
+++ b/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/fileserv/IncomingDataTransfer.java
@@ -489,8 +489,12 @@ public class IncomingDataTransfer extends AbstractTransfer implements HashCheckC
 				return null; // No more chunks, returning null tells the Downloader we're done.
 			}
 			// Check remaining disk space and abort if it's too low
-			if (FileSystem.getAvailableStorageBytes() < MIN_FREE_SPACE_BYTES) {
+			long space = FileSystem.getAvailableStorageBytes();
+			if (space != -1 && space < MIN_FREE_SPACE_BYTES) {
 				downloader.sendErrorCode("Out of disk space");
+				LOGGER.error("Out of space: Cancelling upload of "
+						+ (image == null ? "image" : image.imageName) + " by "
+						+ Formatter.userFullName(owner));
 				cancel();
 				return null;
 			}
-- 
cgit v1.2.3-55-g7522


From 8d273c81cff2b3600e3b118a72aacbad113f581e Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Wed, 24 Feb 2016 17:55:02 +0100
Subject: [server] Log delete actions on images

---
 .../src/main/java/org/openslx/bwlp/sat/thrift/ServerHandler.java | 9 +++++++++
 .../src/main/java/org/openslx/bwlp/sat/util/Formatter.java       | 2 ++
 2 files changed, 11 insertions(+)

(limited to 'dozentenmodulserver/src/main/java')

diff --git a/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/thrift/ServerHandler.java b/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/thrift/ServerHandler.java
index 3244ac95..0ea9921d 100644
--- a/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/thrift/ServerHandler.java
+++ b/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/thrift/ServerHandler.java
@@ -29,6 +29,7 @@ import org.openslx.bwlp.sat.thrift.cache.OperatingSystemList;
 import org.openslx.bwlp.sat.thrift.cache.OrganizationList;
 import org.openslx.bwlp.sat.thrift.cache.VirtualizerList;
 import org.openslx.bwlp.sat.util.FileSystem;
+import org.openslx.bwlp.sat.util.Formatter;
 import org.openslx.bwlp.sat.util.Sanitizer;
 import org.openslx.bwlp.sat.util.Util;
 import org.openslx.bwlp.thrift.iface.AuthorizationError;
@@ -358,8 +359,13 @@ public class ServerHandler implements SatelliteServer.Iface {
 			throw new TInvocationException(InvocationError.INTERNAL_SERVER_ERROR, "VM storage not mounted");
 		User.canDeleteImageVersionOrFail(user, imageVersionId);
 		try {
+			ImageSummaryRead imageSummary = DbImage.getImageSummary(user,
+					DbImage.getBaseIdForVersionId(imageVersionId));
 			DbImage.markForDeletion(imageVersionId);
 			DbImage.setDeletion(DeleteState.WANT_DELETE, imageVersionId);
+			LOGGER.info(Formatter.userFullName(user) + " (" + user.userId + ") deleted Version "
+					+ imageVersionId + " of " + imageSummary.imageName + " (" + imageSummary.imageBaseId
+					+ ")");
 		} catch (SQLException e) {
 			throw new TInvocationException();
 		}
@@ -393,6 +399,9 @@ public class ServerHandler implements SatelliteServer.Iface {
 			}
 			DeleteOldImages.hardDeleteImages();
 		}
+		LOGGER.info(Formatter.userFullName(user) + " (" + user.userId + ") deleted Image "
+				+ imageDetails.imageName + " (" + imageDetails.imageBaseId + ") with all its versions ("
+				+ index + ")");
 		try {
 			DbImage.deleteBasePermanently(imageBaseId);
 		} catch (SQLException e) {
diff --git a/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/util/Formatter.java b/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/util/Formatter.java
index d242d5be..f13df0eb 100644
--- a/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/util/Formatter.java
+++ b/dozentenmodulserver/src/main/java/org/openslx/bwlp/sat/util/Formatter.java
@@ -57,6 +57,8 @@ public class Formatter {
 	}
 
 	public static String userFullName(UserInfo ui) {
+		if (ui == null)
+			return "null";
 		return ui.firstName + " " + ui.lastName;
 	}
 
-- 
cgit v1.2.3-55-g7522