From ca5c046a18f169f10a79cce5c2d0a70b6f08d9aa Mon Sep 17 00:00:00 2001 From: Simon Rettberg Date: Mon, 18 Jun 2018 12:02:54 +0200 Subject: Only apply LDAP filter logic if lecture has any filters... --- src/vsession.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/vsession.cpp b/src/vsession.cpp index 04d0ac2..fc58927 100644 --- a/src/vsession.cpp +++ b/src/vsession.cpp @@ -216,16 +216,16 @@ bool VSession::isActive() const { } // Filter by LDAP data if (!UserLdapData::isEmpty()) { - QDomNode keywordsNode = eintrag_.namedItem("filters"); - for (QDomElement el(keywordsNode.firstChildElement("filter")); - !el.isNull(); - el = el.nextSiblingElement("filter")) { - if (el.attribute("type") != "LDAP") - continue; - if (UserLdapData::isAllowed(el.firstChildElement("key").text(), el.firstChildElement("value").text())) - return true; + QDomElement el(eintrag_.namedItem("filters").firstChildElement("filter")); + if (!el.isNull()) { + for (; !el.isNull(); el = el.nextSiblingElement("filter")) { + if (el.attribute("type") != "LDAP") + continue; + if (UserLdapData::isAllowed(el.firstChildElement("key").text(), el.firstChildElement("value").text())) + return true; + } + return false; } - return false; } return true; -- cgit v1.2.3-55-g7522