From 4a683e74a6afd9896df3c32b9d9d334e4599f7d3 Mon Sep 17 00:00:00 2001
From: Oliver Tappe
Date: Tue, 9 Jun 2009 18:05:47 +0000
Subject: * fixed a whole lot of circular references which I found when
 researching #451 * some minor cleanups along the way

git-svn-id: http://svn.openslx.org/svn/openslx/openslx/trunk@2944 95ad53e4-c205-0410-b2fa-d234c58c8868
---
 os-plugins/plugins/profile/OpenSLX/Distro/Base.pm | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

(limited to 'os-plugins/plugins/profile/OpenSLX/Distro/Base.pm')

diff --git a/os-plugins/plugins/profile/OpenSLX/Distro/Base.pm b/os-plugins/plugins/profile/OpenSLX/Distro/Base.pm
index 3b5508dc..5588a177 100644
--- a/os-plugins/plugins/profile/OpenSLX/Distro/Base.pm
+++ b/os-plugins/plugins/profile/OpenSLX/Distro/Base.pm
@@ -18,7 +18,7 @@ use warnings;
 
 our $VERSION = 1.01;        # API-version . implementation-version
 
-use File::Basename;
+use Scalar::Util qw( weaken );
 
 use OpenSLX::Basics;
 use OpenSLX::Utils;
@@ -37,13 +37,15 @@ sub initialize
 {
     my $self        = shift;
     $self->{engine} = shift;
+    weaken($self->{engine});
+        # avoid circular reference between plugin and its engine
     
     return 1;
 }
 
 sub getXsessionDPath
 {
-    my $self        = shift;
+    my $self = shift;
     
     return "/etc/X11/Xsession.d/10slx-home_env";
 }
@@ -51,21 +53,21 @@ sub getXsessionDPath
 
 sub getProfileDPAth
 {
-    my $self        = shift;
+    my $self = shift;
     
     return "/etc/profile.d/slx-kdehome.sh";
 }
 
 sub getKdeHome
 {
-    my $self        = shift;
+    my $self = shift;
 
     return ".openslx/unknown/kde";
 }
 
 sub getGconfPathConfig
 {
-	my $self        = shift;
+	my $self = shift;
 	
 	return "/etc/gconf/2/path";
 }
@@ -73,7 +75,7 @@ sub getGconfPathConfig
 
 sub getGconfHome
 {
-    my $self        = shift;
+    my $self = shift;
     
     return ".openslx/unknown/gconf";
 }
-- 
cgit v1.2.3-55-g7522