From a4da5d2a9602240ffc85449b7ab18c906b924dcb Mon Sep 17 00:00:00 2001
From: Dirk von Suchodoletz
Date: Wed, 27 May 2009 20:27:22 +0000
Subject: Hints on todos in virtualization plugins ...

git-svn-id: http://svn.openslx.org/svn/openslx/openslx/trunk@2882 95ad53e4-c205-0410-b2fa-d234c58c8868
---
 os-plugins/plugins/qemukvm/OpenSLX/OSPlugin/qemukvm.pm       | 4 +++-
 os-plugins/plugins/virtualbox/OpenSLX/OSPlugin/virtualbox.pm | 3 +++
 os-plugins/plugins/virtualbox/files/run-virt.include         | 6 ++++++
 os-plugins/plugins/vmware/OpenSLX/OSPlugin/vmware.pm         | 2 ++
 4 files changed, 14 insertions(+), 1 deletion(-)

(limited to 'os-plugins/plugins')

diff --git a/os-plugins/plugins/qemukvm/OpenSLX/OSPlugin/qemukvm.pm b/os-plugins/plugins/qemukvm/OpenSLX/OSPlugin/qemukvm.pm
index fe276358..54a91935 100644
--- a/os-plugins/plugins/qemukvm/OpenSLX/OSPlugin/qemukvm.pm
+++ b/os-plugins/plugins/qemukvm/OpenSLX/OSPlugin/qemukvm.pm
@@ -153,7 +153,9 @@ sub _writeRunlevelScript
     my $location = shift;
     my $file     = shift;
     my $kind     = shift;
-    
+   
+    # should use the abstract write runlevel script way, see
+    # http://lab.openslx.org/repositories/revision/openslx/2405 ff.
     my $runlevelScript = $self->{distro}->fillRunlevelScript($location, $kind);
 
     spitFile($file, $runlevelScript);
diff --git a/os-plugins/plugins/virtualbox/OpenSLX/OSPlugin/virtualbox.pm b/os-plugins/plugins/virtualbox/OpenSLX/OSPlugin/virtualbox.pm
index 0ce63150..5ce615c5 100644
--- a/os-plugins/plugins/virtualbox/OpenSLX/OSPlugin/virtualbox.pm
+++ b/os-plugins/plugins/virtualbox/OpenSLX/OSPlugin/virtualbox.pm
@@ -152,8 +152,11 @@ sub _writeRunlevelScript
     my $file     = shift;
     my $kind     = shift;
     
+    # should use the abstract write runlevel script way, see
+    # http://lab.openslx.org/repositories/revision/openslx/2405 ff.
     my $runlevelScript = $self->{distro}->fillRunlevelScript($location, $kind);
 
+
     spitFile($file, $runlevelScript);
 }
 
diff --git a/os-plugins/plugins/virtualbox/files/run-virt.include b/os-plugins/plugins/virtualbox/files/run-virt.include
index 67a333b7..f4c497fd 100644
--- a/os-plugins/plugins/virtualbox/files/run-virt.include
+++ b/os-plugins/plugins/virtualbox/files/run-virt.include
@@ -17,6 +17,7 @@
 # include general configuration from vmchooser
 . /etc/opt/openslx/run-virt.include
 
+# most of the following does not make much sense yet ...
 permem=66
 mem=$(expr{totalmem} * ${permem})
 
@@ -43,7 +44,12 @@ cdrom1=${cdtest:-"FALSE"}
 ide="TRUE"
 hddrv="ide"
 
+# finally set env for run-virt.sh
+################################################################################
 
 # set the variables appropriately (several interfaces with different names)
 VIRTCMD=$(which virtualbox 2>/dev/null)
+# VIRTCMDOPTS="${vmopt} ${conffile}"
+
+
 
diff --git a/os-plugins/plugins/vmware/OpenSLX/OSPlugin/vmware.pm b/os-plugins/plugins/vmware/OpenSLX/OSPlugin/vmware.pm
index ecc2626d..ff3e4ec6 100644
--- a/os-plugins/plugins/vmware/OpenSLX/OSPlugin/vmware.pm
+++ b/os-plugins/plugins/vmware/OpenSLX/OSPlugin/vmware.pm
@@ -386,6 +386,8 @@ sub _writeRunlevelScript
     
     # $location points to the path where vmware helpers are installed
     # call the distrospecific fillup
+    # should use the abstract write runlevel script way, see
+    # http://lab.openslx.org/repositories/revision/openslx/2405 ff.
     my $runlevelScript = $self->{distro}->fillRunlevelScript($location, $kind);
 
     spitFile($file, $runlevelScript);
-- 
cgit v1.2.3-55-g7522