diff options
| author | Thomas Graf | 2005-08-23 19:12:44 +0200 |
|---|---|---|
| committer | David S. Miller | 2005-08-23 19:12:44 +0200 |
| commit | 0fbbeb1ba43bd04f0f1d4f161b7f72437a1c8a03 (patch) | |
| tree | 80aff375f2b1de10a69743d73977df39f356dda5 | |
| parent | [SCTP]: Add SENTINEL to SCTP MIB stats (diff) | |
| download | kernel-qcow2-linux-0fbbeb1ba43bd04f0f1d4f161b7f72437a1c8a03.tar.gz kernel-qcow2-linux-0fbbeb1ba43bd04f0f1d4f161b7f72437a1c8a03.tar.xz kernel-qcow2-linux-0fbbeb1ba43bd04f0f1d4f161b7f72437a1c8a03.zip | |
[PKT_SCHED]: Fix missing qdisc_destroy() in qdisc_create_dflt()
qdisc_create_dflt() is missing to destroy the newly allocated
default qdisc if the initialization fails resulting in leaks
of all kinds. The only caller in mainline which may trigger
this bug is sch_tbf.c in tbf_create_dflt_qdisc().
Note: qdisc_create_dflt() doesn't fulfill the official locking
requirements of qdisc_destroy() but since the qdisc could
never be seen by the outside world this doesn't matter
and it can stay as-is until the locking of pkt_sched
is cleaned up.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/sched/sch_generic.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index 8edefd5d095d..0d066c965342 100644 --- a/net/sched/sch_generic.c +++ b/net/sched/sch_generic.c @@ -438,6 +438,7 @@ struct Qdisc * qdisc_create_dflt(struct net_device *dev, struct Qdisc_ops *ops) if (!ops->init || ops->init(sch, NULL) == 0) return sch; + qdisc_destroy(sch); errout: return NULL; } |