summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHugh Dickins2007-05-16 08:57:04 +0200
committerLinus Torvalds2007-05-17 06:19:15 +0200
commit1800782016fda6fbc9990a0227fec581070f23af (patch)
treeb920bd8d09b9ca5bed90ad4888044067b86053b4
parentSLUB: It is legit to allocate a slab of the maximum permitted size (diff)
downloadkernel-qcow2-linux-1800782016fda6fbc9990a0227fec581070f23af.tar.gz
kernel-qcow2-linux-1800782016fda6fbc9990a0227fec581070f23af.tar.xz
kernel-qcow2-linux-1800782016fda6fbc9990a0227fec581070f23af.zip
slub: don't confuse ctor and dtor
kmem_cache_create() was swapping ctor and dtor in calling find_mergeable(): though it caused no bug, and probably never would, even if destructors are retained; but fix it so as not to generate anxiety ;) Signed-off-by: Hugh Dickins <hugh@veritas.com> Cc: Christoph Lameter <clameter@sgi.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--mm/slub.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/slub.c b/mm/slub.c
index b39c8a69a4ff..5e3e8bc9838f 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2522,7 +2522,7 @@ struct kmem_cache *kmem_cache_create(const char *name, size_t size,
struct kmem_cache *s;
down_write(&slub_lock);
- s = find_mergeable(size, align, flags, dtor, ctor);
+ s = find_mergeable(size, align, flags, ctor, dtor);
if (s) {
s->refcount++;
/*